-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mssql] Incorrect encoding of datatime2 for LocalDateTime values to the ms #977
Comments
DavideD
changed the title
Incorrect encoding of datatype2 for LocalDateTime values to the ms
[mssql] Incorrect encoding of datatype2 for LocalDateTime values to the ms
Jun 9, 2021
@DavideD thanks for the report! |
tsegismont
changed the title
[mssql] Incorrect encoding of datatype2 for LocalDateTime values to the ms
[mssql] Incorrect encoding of datatime2 for LocalDateTime values to the ms
Jun 11, 2021
tsegismont
added a commit
to tsegismont/vertx-sql-client
that referenced
this issue
Jun 11, 2021
Fixes eclipse-vertx#977 LocalTime, LocalDateTime and OffsetDateTime have nanosecond precision. Also, the maximum scale in MSSQL is 7 (hundreds of nanos). So when encoding time-related values, we will always send a value with maximum scale. The server will do round/truncate as necessary. Signed-off-by: Thomas Segismont <[email protected]>
tsegismont
added a commit
to tsegismont/vertx-sql-client
that referenced
this issue
Jun 11, 2021
Fixes eclipse-vertx#977 LocalTime, LocalDateTime and OffsetDateTime have nanosecond precision. Also, the maximum scale in MSSQL is 7 (hundreds of nanos). So when encoding time-related values, we will always send a value with maximum scale. The server will do round/truncate as necessary. Signed-off-by: Thomas Segismont <[email protected]>
tsegismont
added a commit
that referenced
this issue
Jun 11, 2021
Fixes #977 LocalTime, LocalDateTime and OffsetDateTime have nanosecond precision. Also, the maximum scale in MSSQL is 7 (hundreds of nanos). So when encoding time-related values, we will always send a value with maximum scale. The server will do round/truncate as necessary. Signed-off-by: Thomas Segismont <[email protected]>
Rattenkrieg
pushed a commit
to Rattenkrieg/vertx-sql-client
that referenced
this issue
Nov 8, 2021
Fixes eclipse-vertx#977 LocalTime, LocalDateTime and OffsetDateTime have nanosecond precision. Also, the maximum scale in MSSQL is 7 (hundreds of nanos). So when encoding time-related values, we will always send a value with maximum scale. The server will do round/truncate as necessary. Signed-off-by: Thomas Segismont <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
With MS Sql Server.
Testcase to add to
MSSQLPreparedQueryNotNullableDataTypeTest
Result:
The text was updated successfully, but these errors were encountered: