Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expose ColumnDescriptor.getTypeName() #1020

Closed
gavinking opened this issue Aug 5, 2021 · 3 comments · Fixed by #1024
Closed

expose ColumnDescriptor.getTypeName() #1020

gavinking opened this issue Aug 5, 2021 · 3 comments · Fixed by #1024
Labels
enhancement
Milestone
4.2.0

Comments

@gavinking
Copy link

See discussion here: hibernate/hibernate-reactive#903 (comment)
@gavinking gavinking mentioned this issue Aug 5, 2021
Merged
tsegismont added a commit to tsegismont/vertx-sql-client that referenced this issue Aug 17, 2021
@tsegismont
Expose column data type name
f4cc1d4 
Closes eclipse-vertx#1020

The type name is client specific.
The feature won't be supported yet on DB2.

Signed-off-by: Thomas Segismont <[email protected]>
@tsegismont tsegismont mentioned this issue Aug 17, 2021
Merged
@tsegismont tsegismont added this to the 4.2.0 milestone Aug 17, 2021
@tsegismont
Copy link
Contributor

@gavinking this would be fixed in Vert.x 4.2. If it's a blocker, we could consider backporting #1024 to the 4.1 branch.

@gavinking
Copy link
Author

I don't believe it's a blocker, more like a convenience. Right, @gbadner

vietj pushed a commit that referenced this issue Aug 17, 2021
@tsegismont @vietj
Expose column data type name
4c7a056 
Closes #1020

The type name is client specific.
The feature won't be supported yet on DB2.

Signed-off-by: Thomas Segismont <[email protected]>
@gbadner
Copy link

gbadner commented Aug 18, 2021

@gavinking, yes that is correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
4.2.0
Development

Successfully merging a pull request may close this issue.

Expose column data type name tsegismont/vertx-sql-client
3 participants
@gbadner @gavinking @tsegismont