Disable TCCL vertx options #4037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…et the thread context classloader when running actions on a Vert.x context. This options is set by default to the legacy 'vertx.disableTCCL' system property. The warn logged when the TCCL is disabled and the current thread classloader is not the system classloader is removed. fixes #4035 fixes #4036
|
@Sanne please have a look |
|
Looks great, thanks! I'll test it in the afternoon and let you know. |
|
@vietj nice, seems to work as intended when combined with @stuartwdouglas 's quarkusio/quarkus#18875 my draft: |
|
@Sanne is that a green for a merge ? if that so then I'll merge it and backport to 4.1 branch |
|
@vietj yes it's green :) +1 to merge and backport. I couldn't run the full testsuite as that would require me to rebuild lots of projects, but a quick hack shows it works great for our intended purposes on the core components and Hibernate Reactive. I don't expect it to be problematic for the other components, sharing this just for clarity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.