Add check for shared mem payload type #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PLeVasseur
requested changes
Aug 9, 2024
There was a problem hiding this comment.
Hey @brianeaton -- thanks for the PR!
Take a look at some suggestions below.
|
I think I need to fix the workflow triggers for this repo, as they are not firing. I'll go do so, then ask you to rebase and we'll make sure the workflow triggers. |
|
Workflow triggers fix has been merged. Feel free to now rebase and squash to a meaningful commit history. |
matthewd0123
approved these changes
Aug 12, 2024
brianeaton
added a commit
to brianeaton/up-streamer-rust
that referenced
this pull request
Aug 12, 2024
* Prevent payloads of shared memory type from being forwarded Implements [eclipse-uprotocol#30]
brianeaton
added a commit
to brianeaton/up-streamer-rust
that referenced
this pull request
Aug 12, 2024
* Prevent payloads of shared memory type from being forwarded Implements [eclipse-uprotocol#30]
|
@brianeaton -- after we get #20 in, could you please rebase on main, then I'll merge yours? |
PLeVasseur
approved these changes
Aug 12, 2024
brianeaton
added a commit
to brianeaton/up-streamer-rust
that referenced
this pull request
Aug 12, 2024
* Prevent payloads of shared memory type from being forwarded Implements [eclipse-uprotocol#30]
* Prevent payloads of shared memory type from being forwarded Implements [eclipse-uprotocol#30]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any messages received which have UPayloadFormat of UPAYLOAD_FORMAT_SHM should have their UAttributes logged and then dropped.