Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write extra NotificationTest for up-cpp #172 #242

Conversation

pranavishere2
Copy link
Contributor

No description provided.

Copy link

Code coverage report is ready! 📈

Copy link
Contributor

@gregmedd gregmedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change to the NotificationSink::create() call

Copy link

Code coverage report is ready! 📈

@gregmedd
Copy link
Contributor

Looks good. Commits just need to be squashed

@pranavishere2 pranavishere2 force-pushed the notificationExtraTests branch from 395488e to 8ee11bc Compare July 26, 2024 18:45
Copy link

Code coverage report is ready! 📈

@gregmedd gregmedd merged commit 074301e into eclipse-uprotocol:v1.0_up-v1.6.0 Jul 26, 2024
9 checks passed
@gregmedd gregmedd linked an issue Jul 30, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write extra NotificationTest for up-cpp
2 participants