Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove edc-controlplane-memory-hashicorp-vault #903

Conversation

paullatzelsperger
Copy link
Contributor

WHAT

This PR removes the edc-controlplane-memory-hashicorp-vault as it is not used anywhere.

WHY

we should not keep unused code around.

FURTHER NOTES

List other areas of code that have changed but are not necessarily linked to the main feature. This could be method signature changes, package declarations, bugs that were encountered and were fixed inline, etc.

Closes #902

@paullatzelsperger paullatzelsperger added docker Anything to do with docker images github-actions labels Dec 5, 2023
@paullatzelsperger paullatzelsperger force-pushed the chore/remove_memory_hashicorpvault branch from 19c68c9 to 219a17c Compare December 5, 2023 12:15
@paullatzelsperger paullatzelsperger force-pushed the chore/remove_memory_hashicorpvault branch from 1a3422c to 6820b0b Compare December 5, 2023 12:17
Copy link
Contributor

@jimmarino jimmarino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🪓

Copy link

sonarcloud bot commented Dec 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@ndr-brt ndr-brt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🪓

@paullatzelsperger paullatzelsperger merged commit 64e2acc into eclipse-tractusx:main Dec 5, 2023
25 checks passed
@paullatzelsperger paullatzelsperger deleted the chore/remove_memory_hashicorpvault branch December 5, 2023 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docker Anything to do with docker images github-actions
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

Remove edc-controlplane-memory-hashicorp-vault from various publications
3 participants