Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(helm): Replace deprecated WEB_HTTP_IDS_* #876

Merged
merged 2 commits into from
Nov 16, 2023

Conversation

KilianHaag
Copy link
Contributor

WHAT

Replaces the deprecated WEB_HTTP_IDS_* with WEB_HTTP_PROTOCOL_*

WHY

see #875

FURTHER NOTES

Closes #875

@wolf4ood
Copy link
Contributor

Thanks @KilianHaag for this PR

could you please sign the Eclipse ECA?

Thanks

@KilianHaag
Copy link
Contributor Author

@wolf4ood I just signed the ECA. How can I retrigger the check?

@wolf4ood
Copy link
Contributor

Retriggered still not working, check if the email associated with the commit is the same as the one used in the Eclipse account

@KilianHaag
Copy link
Contributor Author

I double checked. When i click on sign, I can only update the signed ECA.
image

But when I try to "Verify ECA" my email: [email protected] is changed to
kilian.haag@t-sy*tems DOT com

image

@ndr-brt
Copy link
Contributor

ndr-brt commented Nov 15, 2023

@KilianHaag please ensure that the email address you used to log in the eclipse portal/sign the ECA is the same of the one used to describe the commit

@KilianHaag
Copy link
Contributor Author

@ndr-brt I double checked again:
image

image

I also received the eclipse account registration email on the same mailbox as your GitHub notification.

I even revoked and signed the ECA again,
image
but it seems like I can't retrigger the "Revalidate", as it still says:
image

Is it possible there is something else amiss?

@KilianHaag
Copy link
Contributor Author

@ndr-brt
In GitHub I had "Keep my email addresses private" set to true.
According to the following issue, this could be the reason.
https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/1704

But when checking https://api.eclipse.org/git/eca/status/gh/eclipse-tractusx/tractusx-edc/876? it shows the correct email and not the no-reply version by github.

Could you retrigger the check a final time, otherwise I have no idea, what I can check/change/do on my side.

@ndr-brt
Copy link
Contributor

ndr-brt commented Nov 15, 2023

tried to re-validate but nothing happened.
@KilianHaag did you add your github id to you eclipse.org account as suggested in the mentioned issue?
at worst please open an issue on the eclipse helpdesk asking for help.

@KilianHaag
Copy link
Contributor Author

@ndr-brt Yes I checked the username as well.
I now created a helpdesk ticket: https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/3959

@KilianHaag
Copy link
Contributor Author

@ndr-brt The validation seems to be fixed now: https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/3959#note_1351746

@ndr-brt
Copy link
Contributor

ndr-brt commented Nov 16, 2023

@KilianHaag ok, please fix the verify-dependencies check and we'll be ready to go

Copy link

sonarcloud bot commented Nov 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ndr-brt ndr-brt self-requested a review November 16, 2023 11:11
Copy link
Contributor

@ndr-brt ndr-brt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@ndr-brt ndr-brt merged commit 1c8441c into eclipse-tractusx:main Nov 16, 2023
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

deprecated WEB_HTTP_IDS_PORT in memory chart
3 participants