Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: generate, merge and publish OpenAPI spec 2 #619

Merged

Conversation

bcronin90
Copy link
Contributor

WHAT

Generates OpenAPI spec for our extensions, merges it with the upstream docs and publishes it. Hopefully does this automatically and with the correct versions.

WHY

#295

Closes #295

@bcronin90 bcronin90 force-pushed the feature/swagger-api-2 branch from 7385ab0 to dbc8435 Compare July 20, 2023 02:13
@bcronin90 bcronin90 marked this pull request as ready for review July 20, 2023 13:13
@bcronin90
Copy link
Contributor Author

This is a successful workflow run:
https://github.com/bcronin90/tractusx-edc/actions/runs/5611012302/jobs/10266762957

I assume the red X-s will go away once DEPENDENCIES are fixed and I rebase. What I cannot test is how the new workflow links up to publish and publish-release. Please review that with care. Thanks.

@bcronin90 bcronin90 force-pushed the feature/swagger-api-2 branch from a732bd2 to a491f12 Compare July 21, 2023 08:43
@bcronin90
Copy link
Contributor Author

Okay. Everything's green. Feel free to review.

Copy link
Contributor

@paullatzelsperger paullatzelsperger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes in the Dockerfiles should be reverted - the change is already in main. You'll have it after rebasing.

Other comments inline.

.github/workflows/publish.yaml Outdated Show resolved Hide resolved
.github/workflows/publish-swaggerhub.yaml Outdated Show resolved Hide resolved
.github/workflows/publish.yaml Show resolved Hide resolved
.github/workflows/publish-swaggerhub.yaml Outdated Show resolved Hide resolved
@bcronin90 bcronin90 force-pushed the feature/swagger-api-2 branch from e9b6189 to b72bc97 Compare July 24, 2023 13:01
@bcronin90
Copy link
Contributor Author

Once again, successful run here: https://github.com/bcronin90/tractusx-edc/actions/runs/5678365723

I just needed to remove the push trigger afterwards.

@bcronin90
Copy link
Contributor Author

Newest version, before the rebase, but still: https://github.com/bcronin90/tractusx-edc/actions/runs/5679954414

@paullatzelsperger
Copy link
Contributor

@bcronin90 the tests fail, because the cUrl version has apparently changed on Alpine. Could you please replace 8.2.0-r1->8.2.1-r0 in all Dockerfiles?

This has nothing to do with your PR, the problem is that Alpine doesn't keep old cUrl versions around.

#686 should fix this problem in the future.

Signed-off-by: Brendan Cronin <[email protected]>
Signed-off-by: Brendan Cronin <[email protected]>
Signed-off-by: Brendan Cronin <[email protected]>
Signed-off-by: Brendan Cronin <[email protected]>
Signed-off-by: Brendan Cronin <[email protected]>
Signed-off-by: Brendan Cronin <[email protected]>
Signed-off-by: Brendan Cronin <[email protected]>
Signed-off-by: Brendan Cronin <[email protected]>
Signed-off-by: Brendan Cronin <[email protected]>
Signed-off-by: Brendan Cronin <[email protected]>
Signed-off-by: Brendan Cronin <[email protected]>
Signed-off-by: Brendan Cronin <[email protected]>
Signed-off-by: Brendan Cronin <[email protected]>
Signed-off-by: Brendan Cronin <[email protected]>
Signed-off-by: Brendan Cronin <[email protected]>
Signed-off-by: Brendan Cronin <[email protected]>
Signed-off-by: Brendan Cronin <[email protected]>
Signed-off-by: Brendan Cronin <[email protected]>
Signed-off-by: Brendan Cronin <[email protected]>
Signed-off-by: Brendan Cronin <[email protected]>
Signed-off-by: Brendan Cronin <[email protected]>
Signed-off-by: Brendan Cronin <[email protected]>
Signed-off-by: Brendan Cronin <[email protected]>
Signed-off-by: Brendan Cronin <[email protected]>
Signed-off-by: Brendan Cronin <[email protected]>
Signed-off-by: Brendan Cronin <[email protected]>
Signed-off-by: Brendan Cronin <[email protected]>
Signed-off-by: Brendan Cronin <[email protected]>
Signed-off-by: Brendan Cronin <[email protected]>
Signed-off-by: Brendan Cronin <[email protected]>
@bcronin90 bcronin90 force-pushed the feature/swagger-api-2 branch from 2bd544c to a85b1af Compare August 8, 2023 07:45
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@paullatzelsperger paullatzelsperger merged commit 1d5dee2 into eclipse-tractusx:main Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

Setup and implement publishing OpenAPI files to SwaggerHub
2 participants