-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: generate, merge and publish OpenAPI spec 2 #619
feat: generate, merge and publish OpenAPI spec 2 #619
Conversation
7385ab0
to
dbc8435
Compare
This is a successful workflow run: I assume the red X-s will go away once DEPENDENCIES are fixed and I rebase. What I cannot test is how the new workflow links up to publish and publish-release. Please review that with care. Thanks. |
a732bd2
to
a491f12
Compare
Okay. Everything's green. Feel free to review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes in the Dockerfiles
should be reverted - the change is already in main
. You'll have it after rebasing.
Other comments inline.
e9b6189
to
b72bc97
Compare
Once again, successful run here: https://github.com/bcronin90/tractusx-edc/actions/runs/5678365723 I just needed to remove the push trigger afterwards. |
Newest version, before the rebase, but still: https://github.com/bcronin90/tractusx-edc/actions/runs/5679954414 |
@bcronin90 the tests fail, because the cUrl version has apparently changed on Alpine. Could you please replace This has nothing to do with your PR, the problem is that Alpine doesn't keep old cUrl versions around. #686 should fix this problem in the future. |
Signed-off-by: Brendan Cronin <[email protected]>
Signed-off-by: Brendan Cronin <[email protected]>
Signed-off-by: Brendan Cronin <[email protected]>
Signed-off-by: Brendan Cronin <[email protected]>
Signed-off-by: Brendan Cronin <[email protected]>
Signed-off-by: Brendan Cronin <[email protected]>
Signed-off-by: Brendan Cronin <[email protected]>
Signed-off-by: Brendan Cronin <[email protected]>
Signed-off-by: Brendan Cronin <[email protected]>
Signed-off-by: Brendan Cronin <[email protected]>
Signed-off-by: Brendan Cronin <[email protected]>
Signed-off-by: Brendan Cronin <[email protected]>
Signed-off-by: Brendan Cronin <[email protected]>
Signed-off-by: Brendan Cronin <[email protected]>
Signed-off-by: Brendan Cronin <[email protected]>
Signed-off-by: Brendan Cronin <[email protected]>
Signed-off-by: Brendan Cronin <[email protected]>
Signed-off-by: Brendan Cronin <[email protected]>
Signed-off-by: Brendan Cronin <[email protected]>
Signed-off-by: Brendan Cronin <[email protected]>
Signed-off-by: Brendan Cronin <[email protected]>
Signed-off-by: Brendan Cronin <[email protected]>
Signed-off-by: Brendan Cronin <[email protected]>
Signed-off-by: Brendan Cronin <[email protected]>
Signed-off-by: Brendan Cronin <[email protected]>
Signed-off-by: Brendan Cronin <[email protected]>
Signed-off-by: Brendan Cronin <[email protected]>
Signed-off-by: Brendan Cronin <[email protected]>
Signed-off-by: Brendan Cronin <[email protected]>
Signed-off-by: Brendan Cronin <[email protected]>
2bd544c
to
a85b1af
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
WHAT
Generates OpenAPI spec for our extensions, merges it with the upstream docs and publishes it. Hopefully does this automatically and with the correct versions.
WHY
#295
Closes #295