Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(test): add integration tests for MIW #585

Conversation

paullatzelsperger
Copy link
Contributor

WHAT

this PR adds tests that assert basic functionality of the MIW (and by extension: the SSI lib).

WHY

Tractus-X EDC relies on MIW as the sole identity backend, so it must make sure that certain functionalities, without which EDC is not functional, are provided.

FURTHER NOTES

  • the test uses the latest-java-did-web tag of the MIW docker image to avoid stale tests
  • currently, the MIW tests are marked continue-on-error, so that they don't block our CI
  • added healthcheck configs to keycloak and postgres
  • added a custom wait script for MIW to become available
  • seeding SQL test data was moved into a separate script (seed.sh), to avoid race conditions between Postgres and MIW

this PR is a duplicate of #555, which was already approved. Unfortunately I had to close and reopen, due to some rebasing weirdness.

Closes # <-- insert Issue number if one exists

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

KICS found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.

@paullatzelsperger paullatzelsperger force-pushed the feature/add_miw_api_tests branch 5 times, most recently from bc74485 to 9a7aed8 Compare July 10, 2023 17:50
@paullatzelsperger paullatzelsperger force-pushed the feature/add_miw_api_tests branch 2 times, most recently from 9b5b15c to 75d003b Compare July 10, 2023 19:50
@paullatzelsperger paullatzelsperger force-pushed the feature/add_miw_api_tests branch from 75d003b to c875f46 Compare July 10, 2023 19:55
@paullatzelsperger paullatzelsperger force-pushed the feature/add_miw_api_tests branch from 6b162d6 to 85933c3 Compare July 10, 2023 20:01
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@paullatzelsperger paullatzelsperger merged commit dfb837d into eclipse-tractusx:main Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

2 participants