Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: replace '__' with '--' in the Sql EDR Store #538

Merged
merged 1 commit into from
Jun 27, 2023
Merged

fix: replace '__' with '--' in the Sql EDR Store #538

merged 1 commit into from
Jun 27, 2023

Conversation

paullatzelsperger
Copy link
Contributor

@paullatzelsperger paullatzelsperger commented Jun 27, 2023 •
edited
Loading

WHAT

Replaces the prefix for EDRs, from edr__ to edr--.

WHY

Some vaults, such as Azure KeyVault, are quite particular about allowed characters, and disallow "__"

FURTHER NOTES

Closes # <-- insert Issue number if one exists

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@paullatzelsperger
Copy link
Contributor Author

Azure Keyvault improvement: eclipse-edc/Technology-Azure#15

@paullatzelsperger paullatzelsperger merged commit 14d9e59 into eclipse-tractusx:main Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wolf4ood wolf4ood wolf4ood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
EDC PR Board
Status: Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paullatzelsperger @wolf4ood