Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace DAPS with SSI in Helm charts #511

Conversation

paullatzelsperger
Copy link
Contributor

@paullatzelsperger paullatzelsperger commented Jun 20, 2023

WHAT

Changes all Helm charts to use SSI/MiW instead of DAPS.
Adds a -legacy helm chart that still uses DAPS, intended as a fallback.

WHY

Replace DAPS with SSI

FURTHER NOTES

  • One chart tractusx-connector-legacy will be left in place that still contains DAPS for fallback purposes. However, this is discontinued and will not be supported anymore. There is no deployment test for it, and it's scheduled for removal in upcoming releases.
  • updated docs/samples/example-dataspace
  • fixed a small bug in our e2e tests, where the MockWebServer didn't get re-instantiated on every test

Closes # <-- insert Issue number if one exists

@paullatzelsperger paullatzelsperger changed the title Feature/add helmchart for ssi Replace DAPS with SSI in Helm charts Jun 20, 2023
@paullatzelsperger paullatzelsperger force-pushed the feature/add_helmchart_for_ssi branch 5 times, most recently from e7957c7 to 6abbe96 Compare June 21, 2023 06:57
@paullatzelsperger paullatzelsperger force-pushed the feature/add_helmchart_for_ssi branch from 6abbe96 to fe33478 Compare June 21, 2023 06:58
@paullatzelsperger
Copy link
Contributor Author

\cc @jimmarino

| web.http.validation.path | X | /validation | |
| web.http.control.port | X | 9999 | |
| web.http.control.path | X | /api/controlplane/control | |
| web.http.ids.port | X | 8282 | |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these ids. properties used anymore?

Copy link
Contributor Author

@paullatzelsperger paullatzelsperger Jun 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't think they are, but the template still exposes them apparently. the README's are regenerated when we publish the helm chart. it's possible that the regenerated version never found it's way back into main. I regenerated them and committed them now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also, this is only in the legacy chart, which will go away eventually

Copy link
Contributor

@wolf4ood wolf4ood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a minor nit on example dataspace README.

I've tested the chart on a local machine with a real MIW and Keycloak running.

Tested with MIW revision catenax-ng/tx-managed-identity-wallets@bed8bd6

docs/samples/example-dataspace/README.md Outdated Show resolved Hide resolved
docs/samples/example-dataspace/README.md Outdated Show resolved Hide resolved
@paullatzelsperger
Copy link
Contributor Author

LGTM, just a minor nit on example dataspace README.

I've tested the chart on a local machine with a real MIW and Keycloak running.

Tested with MIW revision catenax-ng/tx-managed-identity-wallets@bed8bd6

Thanks @wolf4ood for doing this 🤟 I think we're on a good track then!

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@paullatzelsperger paullatzelsperger merged commit 3c421a7 into eclipse-tractusx:main Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

4 participants