-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace DAPS with SSI in Helm charts #511
Replace DAPS with SSI in Helm charts #511
Conversation
e7957c7
to
6abbe96
Compare
6abbe96
to
fe33478
Compare
\cc @jimmarino |
| web.http.validation.path | X | /validation | | | ||
| web.http.control.port | X | 9999 | | | ||
| web.http.control.path | X | /api/controlplane/control | | | ||
| web.http.ids.port | X | 8282 | | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these ids.
properties used anymore?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i don't think they are, but the template still exposes them apparently. the README's are regenerated when we publish the helm chart. it's possible that the regenerated version never found it's way back into main
. I regenerated them and committed them now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also, this is only in the legacy
chart, which will go away eventually
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a minor nit on example dataspace README
.
I've tested the chart on a local machine with a real MIW and Keycloak running.
Tested with MIW revision catenax-ng/tx-managed-identity-wallets@bed8bd6
Co-authored-by: Enrico Risa <[email protected]>
Thanks @wolf4ood for doing this 🤟 I think we're on a good track then! |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
WHAT
Changes all Helm charts to use SSI/MiW instead of DAPS.
Adds a
-legacy
helm chart that still uses DAPS, intended as a fallback.WHY
Replace DAPS with SSI
FURTHER NOTES
tractusx-connector-legacy
will be left in place that still contains DAPS for fallback purposes. However, this is discontinued and will not be supported anymore. There is no deployment test for it, and it's scheduled for removal in upcoming releases.docs/samples/example-dataspace
MockWebServer
didn't get re-instantiated on every testCloses # <-- insert Issue number if one exists