feat(build): only increase patch version on final releases #508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
\cc @jimmarino |
|
Kudos, SonarCloud Quality Gate passed!
|
jimmarino
approved these changes
Jun 20, 2023
wolf4ood
approved these changes
Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
This PR improves the release workflow by changing the logic where the new snapshot version is selected.
Assuming
<major>.<minor>.<patch>versions, previously, we always incremented thepatchversion, regardless of what the input was. So0.5.0-rc1would have resulted in a0.5.1-SNAPSHOT, which is incorrect.Now, we only increase the
<patch>version, if there is no-rc1or anything:0.5.0becomes0.5.1-SNAPSHOT0.5.0-rc1becomes0.5.0-SNAPSHOTWHY
The existing logic would have handled release candidates etc. incorrectly.
FURTHER NOTES
List other areas of code that have changed but are not necessarily linked to the main feature. This could be method signature changes, package declarations, bugs that were encountered and were fixed inline, etc.
Closes # <-- insert Issue number if one exists