Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: add helm doc check to PR verification #503

Merged

Conversation

bcronin90
Copy link
Contributor

WHAT

Add a check to PR verification to check helm doc validity

WHY

#262

FURTHER NOTES

Closes #262

bcronin90 added 13 commits June 23, 2023 12:13
Signed-off-by: Brendan Cronin <[email protected]>
Signed-off-by: Brendan Cronin <[email protected]>
Signed-off-by: Brendan Cronin <[email protected]>
Signed-off-by: Brendan Cronin <[email protected]>
Signed-off-by: Brendan Cronin <[email protected]>
Signed-off-by: Brendan Cronin <[email protected]>
Signed-off-by: Brendan Cronin <[email protected]>
Signed-off-by: Brendan Cronin <[email protected]>
Signed-off-by: Brendan Cronin <[email protected]>
Signed-off-by: Brendan Cronin <[email protected]>
Signed-off-by: Brendan Cronin <[email protected]>
Signed-off-by: Brendan Cronin <[email protected]>
@bcronin90 bcronin90 force-pushed the feature/ensure-api-doc branch from f302bf5 to a7e8cbf Compare June 23, 2023 10:13
@bcronin90 bcronin90 changed the title Add helm doc check to PR verification Feat: add helm doc check to PR verification Jun 23, 2023
@bcronin90 bcronin90 marked this pull request as ready for review June 23, 2023 10:30
.github/workflows/verify.yaml Outdated Show resolved Hide resolved
.github/workflows/verify.yaml Outdated Show resolved Hide resolved
bcronin90 and others added 2 commits June 23, 2023 12:37
Co-authored-by: Paul Latzelsperger <[email protected]>
Signed-off-by: Brendan Cronin <[email protected]>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.5% 0.5% Duplication

@paullatzelsperger paullatzelsperger merged commit 3794f44 into eclipse-tractusx:main Jun 23, 2023
@bcronin90 bcronin90 deleted the feature/ensure-api-doc branch June 23, 2023 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

Ensure helm chart README.md's are in sync with the go-template
2 participants