chore(helm): move test value file for memory chart to common directory #486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move and rename the tractusx-connector-memory test values.yaml to the same location as other test value files
paullatzelsperger
approved these changes
Jun 15, 2023
|
@fty4 if you could rebase and solve conflicts i'll merge |
|
Kudos, SonarCloud Quality Gate passed!
|
|
@paullatzelsperger solved conflicts and tests passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
Move and rename the
tractusx-connector-memorytesting values file to the same location as other test value files.WHY
Currently the values file for all tests are located inside
edc-tests/deployment/src/main/resources/helmwith the exception of the tractusx-connector-memory values file.This should be unified to the same path.
FURTHER NOTES
also see different locations in the workflow
deployment-test:tractusx-edc/.github/workflows/deployment-test.yaml
Line 106 in b1be1fe
tractusx-edc/.github/workflows/deployment-test.yaml
Line 82 in b1be1fe
tractusx-edc/.github/workflows/deployment-test.yaml
Line 136 in b1be1fe
Marco Lecheler [email protected] Mercedes-Benz Tech Innovation GmbH (ProviderInformation)