-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Jws2020 cryptosuite #483
Merged
paullatzelsperger
merged 7 commits into
eclipse-tractusx:main
from
paullatzelsperger:feature/482_add_jws_2020_cryptosuite
Jun 16, 2023
Merged
feat: add Jws2020 cryptosuite #483
paullatzelsperger
merged 7 commits into
eclipse-tractusx:main
from
paullatzelsperger:feature/482_add_jws_2020_cryptosuite
Jun 16, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paullatzelsperger
force-pushed
the
feature/482_add_jws_2020_cryptosuite
branch
from
June 14, 2023 15:20
ef09449
to
e3344c6
Compare
paullatzelsperger
force-pushed
the
feature/482_add_jws_2020_cryptosuite
branch
from
June 14, 2023 15:21
e3344c6
to
b44d660
Compare
ndr-brt
approved these changes
Jun 16, 2023
...jws2020-crypto-suite/src/main/java/org/eclipse/edc/security/signature/jws2020/JwkMethod.java
Outdated
Show resolved
Hide resolved
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
...2020-crypto-suite/src/main/java/org/eclipse/edc/security/signature/jws2020/IssuerCompat.java
Show resolved
Hide resolved
wolf4ood
approved these changes
Jun 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
Adds the JsonWebSignature2020 crypto suite for use with VerifiableCredentials and VerifiablePresentations.
WHY
Catena-X mandates the use of JsonWebSignature2020 for VerifiableCredentials and VerifiablePresentations, so we'll need to be able to verify proofs created with that cryptosuite.
Known limitations
did:key
verification method is not supported due to implementation feasibility concerns and the fact that the Multibase java impl, that iron relies on, is not available on MavenCentraldid:key
method is possible, but only if thedid:key
is generated out-of-bandOctetKeyPair
s are only supported, if the tink library is present at runtime. They arent' supported by the Java17 JCA yet.true
Closes #482