Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Jws2020 cryptosuite #483

Conversation

paullatzelsperger
Copy link
Contributor

@paullatzelsperger paullatzelsperger commented Jun 14, 2023

WHAT

Adds the JsonWebSignature2020 crypto suite for use with VerifiableCredentials and VerifiablePresentations.

WHY

Catena-X mandates the use of JsonWebSignature2020 for VerifiableCredentials and VerifiablePresentations, so we'll need to be able to verify proofs created with that cryptosuite.

Known limitations

  • verifying VC/VP that have been signed with the did:key verification method is not supported due to implementation feasibility concerns and the fact that the Multibase java impl, that iron relies on, is not available on MavenCentral
  • signing VC/VP with the did:key method is possible, but only if the did:key is generated out-of-band
  • OctetKeyPairs are only supported, if the tink library is present at runtime. They arent' supported by the Java17 JCA yet.
  • switched Checkstyle verbosity to default true

Closes #482

@paullatzelsperger
Copy link
Contributor Author

paullatzelsperger commented Jun 14, 2023

@paullatzelsperger paullatzelsperger force-pushed the feature/482_add_jws_2020_cryptosuite branch from ef09449 to e3344c6 Compare June 14, 2023 15:20
@paullatzelsperger paullatzelsperger force-pushed the feature/482_add_jws_2020_cryptosuite branch from e3344c6 to b44d660 Compare June 14, 2023 15:21
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 9 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@wolf4ood wolf4ood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@paullatzelsperger paullatzelsperger merged commit d41c59f into eclipse-tractusx:main Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

SSI: Add support for JsonWebSignature2020
4 participants