feat: strict policy definition validation #1688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolf4ood
force-pushed
the
feat/1685_strict_policy_validation
branch
4 times, most recently
from
eb12b7e to
fd0ac23
Compare
wolf4ood
force-pushed
the
feat/1685_strict_policy_validation
branch
from
e19ba3a to
3570aad
Compare
|
/cc @gerbigf |
charts/tractusx-connector-azure-vault/templates/deployment-controlplane.yaml
Outdated
Show resolved
Hide resolved
...sions/bdrs-client/src/main/java/org/eclipse/tractusx/edc/identity/mapper/BdrsClientImpl.java
Outdated
Show resolved
Hide resolved
|
ndr-brt
approved these changes
Nov 28, 2024
rafaelmag110
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
Enables strict policy definition validation by default. If necessary the validation can be disabled with helm configuration/ env variables.
Two additional Constraint functions were introduced:
ContractReferenceConstraintFunction(cx-policy:ContractReference)UsagePurposeConstraintFunction(cx-policy:UsagePurpose)Both evaluate to
truealways, they are only there as placeholder for enabling the validation of policy definitions.WHY
user experience
FURTHER NOTES
The current validation only checks if there are functions that can be evaluated with the posted policy definition and the left operand is bound to at least a policy context.
Additional validation could be introduced in policy functions by implementing
AtomicConstraintRuleFunction#validatewhich allows validating for example right operand values and operators supported.Closes #1685