-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix BPNL Group validation operators logic #1673
Fix BPNL Group validation operators logic #1673
Conversation
… into fix_bpnl_group_validation_operators_logic
… into fix_bpnl_group_validation_operators_logic
… into fix_bpnl_group_validation_operators_logic
This pull request is stale because it has been open for 7 days with no activity. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my suggestion would be to just deprecate the eq
and neq
operators with a warn log printed, to be removed in the next versions.
.../eclipse/tractusx/edc/validation/businesspartner/functions/BusinessPartnerGroupFunction.java
Outdated
Show resolved
Hide resolved
.../eclipse/tractusx/edc/validation/businesspartner/functions/BusinessPartnerGroupFunction.java
Show resolved
Hide resolved
.../eclipse/tractusx/edc/validation/businesspartner/functions/BusinessPartnerGroupFunction.java
Outdated
Show resolved
Hide resolved
.../eclipse/tractusx/edc/validation/businesspartner/functions/BusinessPartnerGroupFunction.java
Outdated
Show resolved
Hide resolved
.../eclipse/tractusx/edc/validation/businesspartner/functions/BusinessPartnerGroupFunction.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
almost there
.../eclipse/tractusx/edc/validation/businesspartner/functions/BusinessPartnerGroupFunction.java
Outdated
Show resolved
Hide resolved
.../org/eclipse/tractusx/edc/validation/businesspartner/BusinessPartnerValidationExtension.java
Outdated
Show resolved
Hide resolved
...ipse/tractusx/edc/validation/businesspartner/functions/BusinessPartnerGroupFunctionTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@bmg13 please fix dependencies check and we'll be ready to go |
… into fix_bpnl_group_validation_operators_logic
Quality Gate passedIssues Measures |
@ndr-brt took a few tries, but is done :) thank you! |
WHAT
Fixes some of the existing BPN Group validation operators' scope and proposes the removal of potentially redundant ones.
WHY
Too keep the expected behaviour of some operators, specially the
isAllOf
since was not validating properly (switched the assigned and allowed groups in the validation).FURTHER NOTES
The suggestions are based on expected behaviour (
isAllOf
should check if all the allowed groups are present in the assigned groups) and potential improvements (eq
eneq
could maybe be removed since they do not seem to add much value whenisAllOf
,isAnyOf
andisNoneOf
exist).Changed the
BpnGroupHolder
properties to Sets simply to easily avoid repeated entries.Tests updated accordingly.
Closes #1665