docs: add decision record to make release manual #1653
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ndr-brt
approved these changes
Oct 28, 2024
Comment on lines
+11
to
+12
| - GH only allows for the `on pull_request` event to be of type `closed`. This works fine when a PR is merged but will | ||
| also trigger |
There was a problem hiding this comment.
Suggested change
| - GH only allows for the `on pull_request` event to be of type `closed`. This works fine when a PR is merged but will | |
| also trigger | |
| - GH only allows for the `on pull_request` event to be of type `closed`. This works fine when a PR is merged but it will | |
| also trigger the event |
| with skipped run logs. | ||
|
|
||
| Additionally: | ||
| - We keep a dedicated `manual-release-bugfix` workflow to manually trigger a bugfix release because it is done under |
There was a problem hiding this comment.
Suggested change
| - We keep a dedicated `manual-release-bugfix` workflow to manually trigger a bugfix release because it is done under | |
| - We are keeping a dedicated `manual-release-bugfix` workflow to manually trigger a bugfix release because it is done under |
paullatzelsperger
approved these changes
Nov 4, 2024
| different conditions. | ||
| This workflow re-uses the main release workflow. There is no need to keep the `manual-release-bugfix` workflow if the | ||
| main release workflow is manually triggered. | ||
| - Workflow can only be triggered by commiters so control over releases and its conditions is guaranteed. |
There was a problem hiding this comment.
Suggested change
| - Workflow can only be triggered by commiters so control over releases and its conditions is guaranteed. | |
| - Workflow can only be triggered by committers, so control over releases and its conditions is guaranteed. |
|
closed because replaced by #1666 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
Adds a decision record to make the release workflow trigger via manual dispatch only.
WHY
Check #1652
Closes #1652