fix: prevent default identity extractor from being registered #1597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolf4ood
approved these changes
Sep 30, 2024
|
paullatzelsperger
deleted the
fix/prevent_default_identity_extractor
branch
paullatzelsperger
added a commit
to paullatzelsperger/tractusx-edc
that referenced
this pull request
Oct 1, 2024
…e-tractusx#1597) * fix(dcp): prevent default identity extractor from being registered * fix unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
This PR prevents the upstream
DefaultDcpParticipantAgentServiceExtensionfrom being registered with theParticipantAgentServiceby declaring a provider method for theIatpIdentityExtractorWHY
the
IatpIdentityExtractorwas not added to the service context, which means, that at runtime, both theDefaultDcpParticipantAgentServiceExtensionand theIatpIdentityExtractorare present.That means, that whichever is registered first, determines the ID property of the ParticipantAgent, either
credentialSubject.Id, orcredentialSubject.holderIdentifier. We need the latter, because that contains the BPN.FURTHER NOTES
The fact that this bug hasn't surfaced earlier is pure chance, because apparently the
IatpIdentityExtractorgot registered later.Closes # <-- insert Issue number if one exists