fix: upgradeability tests #1529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolf4ood
force-pushed
the
fix/1528_upgradeability_tests
branch
from
fe2a209 to
80a1dd3
Compare
wolf4ood
force-pushed
the
fix/1528_upgradeability_tests
branch
from
80a1dd3 to
6d119fc
Compare
|
ndr-brt
reviewed
Sep 3, 2024
|
this is a fix for migration from 0.7.4 to future 0.8.0, we don't have yet a final 0.8.0 just RCs. We backported the migration here for the data plane instance store but the init migration file differs from the one in main, hence the test upgradeability 0.7.4 -> main fails |
ndr-brt
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
upgradeability tests
WHY
upgradeability tests are failing on `main
FURTHER NOTES
To fix that we have to change the
V0_0_1__Init_Dataplaneinstance.sqlto be equal to the one in 0.7.4. By doing so the migration from0.8.0-rc2to the next RC version0.8.0-rc3will fail instead.Closes #1528