-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(workflows): Adds workflow to release hotfix version #1511
chore(workflows): Adds workflow to release hotfix version #1511
Conversation
makeLatest: false | ||
removeArtifacts: true | ||
|
||
publish-to-swaggerhub: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the job to publish the API spec to GH Pages is missing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was a copy of the existing publish-new-release workflow. That workflow did not contain the publication to GH pages so I left it out.
Publishing to GH pages started after 0.7.3 was released. Does it make sense to add the 0.7.4 specs to GH pages?
@paullatzelsperger |
I understand that this is supposed to be a temporary workflow, but once these kinds of things are in the code base, they have a habit of remaining there, or be used as reference later. So I'd rather have a temporary, clean WF now, of which we could - in good conscience - borrow elements later.
I'm sorry, but "it's hard/annoying to do" isn't a valid reason IMO. |
I'm also not an adept of doing half-solutions, and I do understand your point that "there isn't a more permanent solution than a temporary one". As with everything, there are exceptions and considering a permanent solution is imminent this was one of them. |
Quality Gate passedIssues Measures |
@wolf4ood @paullatzelsperger |
572a365
into
eclipse-tractusx:bugfix/0.7.4
I don't think we need this in |
…actusx#1511) * Add publish-hotfix-release.yml * Adds prepare-hotfix-release job * Fix Copyright header * Replace unecessary check-tag action * Comment * Remove unecessary variable * Remove unnecessary Job and its dependencies * checked permissions * Change branch validation from hotfix to bugfix * rename file
* chore(workflows): Adds workflow to release hotfix version (#1511) * Add publish-hotfix-release.yml * Adds prepare-hotfix-release job * Fix Copyright header * Replace unecessary check-tag action * Comment * Remove unecessary variable * Remove unnecessary Job and its dependencies * checked permissions * Change branch validation from hotfix to bugfix * rename file * Updates workflow with changes done to main * trigger CI
WHAT
Adds a temporary workflow to enable the release of bugfix versions.
This workflow should be reworked as it contains duplicate code from draft-new-release and publish-new-release.
This workflow, as is, should be executed after the hotfix branch is created and all needed PRs are merged
WHY
To release 0.7.4 and since the current publish-new-release workflow doesn't work for hotfix releases.
FURTHER NOTES