Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add decision record about removing Lombok #143

Conversation

paullatzelsperger
Copy link
Contributor

WHAT

creates a decision record about completely excising Lombok from our code base

WHY

Lombok uses undocumented and non-public APIs of the JVM and is expected to break in upcoming Java releases.

Copy link
Contributor

@ndr-brt ndr-brt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Totally agree, I took a glance at the issue on the lombok repository and I think all this noise just to save some constructors and methods seems to much.
🪓

@tuncaytunc-zf
Copy link
Contributor

To be fair, we should also mention some advantages of Lombok

  • Avoid boilerplate code
  • Save time
  • Clean code
  • Open Source with huge community behind
  • ...
    I have used it also in many other projects can't say that it is a bad tool.

Copy link
Contributor

@wolf4ood wolf4ood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🪓

@SebastianBezold
Copy link
Contributor

Hi @tuncaytunc-zf,
reading your comment, I cannot really see, if you're against this change. I want to avoid merging PRs, if the team is not aligned. Can you please clarify, if you do support the decision beside your topics from the comment?

@tuncaytunc-zf
Copy link
Contributor

Hi @tuncaytunc-zf, reading your comment, I cannot really see, if you're against this change. I want to avoid merging PRs, if the team is not aligned. Can you please clarify, if you do support the decision beside your topics from the comment?

Hi @SebastianBezold I just wanted to point out that it has also some advantages, but indeed the points in D-R are some potential risks and if most of us are against Lombok then of course it can be removed. So please merge it.

@SebastianBezold SebastianBezold merged commit 28dc524 into eclipse-tractusx:develop Mar 24, 2023
This was referenced Mar 27, 2023
paullatzelsperger pushed a commit to paullatzelsperger/tractusx-edc that referenced this pull request May 4, 2023
…_record_remove_lombok

docs: add decision record about removing Lombok
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants