Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(charts): cleanup unneeded version checks #1424

Merged

Conversation

ndr-brt
Copy link
Contributor

@ndr-brt ndr-brt commented Jul 16, 2024

WHAT

Cleanup unnecessary version checks on ingresses

WHY

oldest supported k8s version is 1.28

FURTHER NOTES

List other areas of code that have changed but are not necessarily linked to the main feature. This could be method signature changes, package declarations, bugs that were encountered and were fixed inline, etc.

Closes #1423

@ndr-brt ndr-brt added the refactoring Refactoring, does not add functionality label Jul 16, 2024
Copy link
Contributor

@paullatzelsperger paullatzelsperger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔪

Copy link
Contributor

@wolf4ood wolf4ood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✂️

@ndr-brt ndr-brt merged commit 76b18db into eclipse-tractusx:main Jul 16, 2024
34 checks passed
@ndr-brt ndr-brt deleted the 1423-cleanup-chart-ingress branch July 16, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Refactoring, does not add functionality
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

cleanup k8s version checks
3 participants