refactor: deprecate dataplane-selector-configuration in favor of self-registration #1329
Conversation
ndr-brt
force-pushed
the
1325-dataplane-self-registration
branch
20 times, most recently
from
f2778db to
a2b0bb0
Compare
| @@ -34,7 +34,7 @@ dependencies { | |||
| runtimeOnly(libs.edc.core.did) // for the DID Public Key Resolver | |||
| runtimeOnly(libs.edc.identity.did.web) | |||
| runtimeOnly(libs.edc.config.filesystem) | |||
| runtimeOnly(libs.edc.auth.tokenbased) | |||
| // runtimeOnly(libs.edc.auth.tokenbased) | |||
There was a problem hiding this comment.
| // runtimeOnly(libs.edc.auth.tokenbased) |
There was a problem hiding this comment.
yes, I was just discovering that for some reasons I got 401 on the readiness check, commenting that solves the problem, in any case data-plane api are only supposed to be called by control plane so they they don't have to be secured (for the moment), I just removed that dependency because it does not make sense as it is supposed to secure management-api endpoints.
There was a problem hiding this comment.
the Observability API (which contains the readiness check) should not be secured, but it also should never be exposed outside of the pod.
yes, commenting (or better: removing) this line may solve the problem, but if somehow the TokenBasedAuthenticationService fires for the Observability API, that would be a bug that would be worth investigating.
[edit]: my point was about removing, rather than commenting out :)
…-plane-self-registration
ndr-brt
force-pushed
the
1325-dataplane-self-registration
branch
from
a2b0bb0 to
e07562e
Compare
|
WHAT
Deprecate
dataplane-selector-configuration(printing warning whether a related configuration is set) , and adddata-plane-self-registrationon the data-plane ones.WHY
data plane self-registration
FURTHER NOTES
Closes #1325