chore: make required props mandatory #1253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paullatzelsperger
force-pushed
the
chore/make_required_props_mandatory
branch
2 times, most recently
from
6c8b892 to
42ad92b
Compare
wolf4ood
approved these changes
Apr 25, 2024
paullatzelsperger
force-pushed
the
chore/make_required_props_mandatory
branch
from
6c0d25d to
875a9b1
Compare
|
jimmarino
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
throws an exception when required config values are missing. Previously only a
SEVERElog was written, which may get overlooked.Now, the runtime doesn't boot if required values aren't configured.
WHY
To avoid ambiguities and unexpected problems at runtime.
FURTHER NOTES
14.2 -> 16.2Closes # <-- insert Issue number if one exists