Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EDR API: EDR get stuck in REFRESHING state #837

Closed
dreni opened this issue Oct 19, 2023 · 2 comments · Fixed by #855
Closed

EDR API: EDR get stuck in REFRESHING state #837

dreni opened this issue Oct 19, 2023 · 2 comments · Fixed by #855
Assignees

Comments

@dreni
Copy link

dreni commented Oct 19, 2023

WHAT

The EDR renewal doesn't always work when e.g. MIW verification failed. For the specific asset one can't start another EDR request until the 'failed" EDR stuck in REFRESHING state isn't deleted.

In background a retry should happen or a clean up of the failed EDR, if the error of external services (e.g. MIW) still remains.

@drhansbeck
Copy link

This is in 0.6.0-rc2 - see #855 listed in https://github.com/eclipse-tractusx/tractusx-edc/releases

Hi @wolf4ood , @dreni , @paullatzelsperger !

Thanks for this fix!! Wonderful to see the Tractus-X commnity working together nicely!!

Possibly: does it make sense to a add 0.6.0-rc2 milestone tag (and hopefully later the 0.6.0 tag)? I very much like the comprehensive listing in https://github.com/eclipse-tractusx/tractusx-edc/releases . Having release tags on issues would easily allow users who suspect that they are affected to i) check their version against the "fixed in" version ii) allow for their upgrade planning.
I know this might be too much work, I totally respect that.

Again:: big thanks for the fix and the good release documentation!!

Best,
Hans

@paullatzelsperger
Copy link
Contributor

@drhansbeck I don't know of a way to link issues to releases other than listing them in a release changelog.
Milestones are not the same thing as releases and they don't always correlate 1:1. Also, we would need a way to link one issue to multiple milestones, because some fixes may be present in multiple releases, just think of backported bugfixes.

I understand the desire to know in which version a desired fix is contained, I think GitHub does not offer that out-of-the box. maybe some third-party tooling exists?

wolf4ood added a commit to wolf4ood/tractusx-edc that referenced this issue Jan 31, 2024
wolf4ood added a commit that referenced this issue Jan 31, 2024
* chore: backport of #837

* chore: remove mk linter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants