Skip to content

Commit

Permalink
Review suggestions
Browse files Browse the repository at this point in the history
  • Loading branch information
rafaelmag110 committed Sep 18, 2024
1 parent cc667fe commit e7d680d
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 8 deletions.
12 changes: 6 additions & 6 deletions .github/actions/publish-tag-and-release/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ inputs:
token:
required: true
description: "Github token"
isLatest:
is_latest:
required: true
description: "Boolean that defines if a release is latest or not"

Expand All @@ -52,19 +52,19 @@ runs:
git tag
# Create & push tag
git tag --force ${{ inputs.version }}
git push --force origin ${{ inputs.version }}
git tag ${{ inputs.version }}
git push origin ${{ inputs.version }}
- name: Create GitHub Release
uses: ncipollo/release-action@v1
with:
generateReleaseNotes: true
tag: ${{ inputs.version }}
token: ${{ inputs.token }}
makeLatest: ${{ inputs.isLatest }}
makeLatest: ${{ inputs.is_latest }}
removeArtifacts: true
- uses: ./.github/actions/setup-java
- name: Set new snapshot version
if: ${{ inputs.isLatest }}
if: ${{ inputs.is_latest }}
shell: bash
run: |
# Extract release version
Expand All @@ -79,7 +79,7 @@ runs:
echo "${{ inputs.version }} is not a final release version (contains \"$SNAPSHOT\"), will not increase patch"
fi
VERSION="$RELEASE_VERSION_MAJOR.$RELEASE_VERSION_MINOR.$((RELEASE_VERSION_PATCH+$INC))-SNAPSHOT"
VERSION="$RELEASE_VERSION_MAJOR.$((RELEASE_VERSION_MINOR+$INC)).0-SNAPSHOT"
SNAPSHOT_VERSION=$VERSION
# Persist the "version" in the gradle.properties
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/draft-release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ on:

jobs:
validate-release:
name: "Validate if version can be released"
name: "Validates that tag does not already exist"
runs-on: ubuntu-latest
if: ${{ github.ref_name == 'main' || startsWith(github.ref, 'refs/tags/') }}
steps:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ jobs:
with:
version: ${{ needs.release-version.outputs.RELEASE_VERSION }}
token: ${{ secrets.GITHUB_TOKEN }}
isLatest: ${{ github.ref_name == 'main' }}
is_latest: ${{ github.ref_name == 'main' }}

# Release: Publish specs to SwaggerHub
publish-to-swaggerhub:
Expand Down

0 comments on commit e7d680d

Please sign in to comment.