Skip to content

Commit

Permalink
pr remarks
Browse files Browse the repository at this point in the history
  • Loading branch information
wolf4ood committed Jun 12, 2023
1 parent 7c92538 commit cb45576
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 5 deletions.
7 changes: 4 additions & 3 deletions edc-extensions/ssi/ssi-identity-core/README.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
# SSI Core Identity Service Module

This module contains an implementation of the EDC identity service for SSI. The SsiIdentityService a `SsiTokenValidationService` for validating the `JWT` token
Ultimately the validation is delegated to an implementation of `SsiCredentialClient`.
This module contains an implementation of the EDC identity service for SSI.
The SsiIdentityService contains a `SsiTokenValidationService` for validating the `JWT` token,
that uses an implementation of `SsiCredentialClient` for validating the JWT token and then check custom rules registered in the `SsiValidationRuleRegistry`

For obtaining the `JWT` token, the identity service also delegate to the `SsiCredentialClient` .

Expand All @@ -12,7 +13,7 @@ The implementation also provide a rule registry `SsiValidationRuleRegistry` wher

Custom rule could be like:

- audience validation
- Audience validation
- VP/VC validation
- Expiration
- ..etc
Expand Down
4 changes: 2 additions & 2 deletions edc-extensions/ssi/ssi-miw-credential-client/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,12 @@
This module contains an implementation of the `SsiCredentialClient` interface for SSI.
It basically narrow down to two operations:

- obtaining a token for protocol communication
- validating the token
- Obtaining a token for protocol communication

For validating the token accordingly to the first milestone [here](https://github.com/eclipse-tractusx/ssi-docu/tree/main/docs/architecture/cx-3-2), the implemetation
just call the MIW for checking that the token and the VP claim inside are correct. Then extract the `JWT` claims into the `ClaimToken` for further checks.

For obtaining a `JWT` token also it reaches the MIW, that will create a token with the `VP` claim inside.

The MIW interaction in this first implementation it's still WIP, since the MIW interface it's not stable or complete yet.
The MIW interaction in this first implementation is still WIP, since the MIW interface it's not stable or complete yet.

0 comments on commit cb45576

Please sign in to comment.