Updates and improcvements based on Paul's review

eclipse-tractusx · May 17, 2023 · 2a19850 · 2a19850
1 parent 4cb9b0b
commit 2a19850
Show file tree

Hide file tree

Showing 6 changed files with 41 additions and 5 deletions.
diff --git a/.../org/eclipse/tractusx/edc/dataplane/proxy/consumer/api/asset/ConsumerAssetRequestApi.java b/.../org/eclipse/tractusx/edc/dataplane/proxy/consumer/api/asset/ConsumerAssetRequestApi.java
@@ -25,7 +25,7 @@
 import org.eclipse.tractusx.edc.dataplane.proxy.consumer.api.asset.model.AssetRequest;
 
 /**
- *
+ * Defines the API for receiving asset requests on a consumer.
  */
 @OpenAPIDefinition
 @Tag(name = "Data Plane Proxy API")

diff --git a/...umer-api/src/main/resources/META-INF/services/org.eclipse.edc.spi.system.ServiceExtension b/...umer-api/src/main/resources/META-INF/services/org.eclipse.edc.spi.system.ServiceExtension
@@ -1 +1,13 @@
-org.eclipse.tractusx.edc.dataplane.proxy.consumer.api.DataPlaneProxyConsumerApiExtension
+ #
+ #  Copyright (c) 2023 Bayerische Motoren Werke Aktiengesellschaft (BMW AG)
+ #
+ #  This program and the accompanying materials are made available under the
+ #  terms of the Apache License, Version 2.0 which is available at
+ #  https://www.apache.org/licenses/LICENSE-2.0
+ #
+ #  SPDX-License-Identifier: Apache-2.0
+ #
+ #  Contributors:
+ #       Bayerische Motoren Werke Aktiengesellschaft (BMW AG) - initial API and implementation
+
+ org.eclipse.tractusx.edc.dataplane.proxy.consumer.api.DataPlaneProxyConsumerApiExtension
diff --git a/...n/java/org/eclipse/tractusx/edc/dataplane/proxy/provider/api/response/ResponseHelper.java b/...n/java/org/eclipse/tractusx/edc/dataplane/proxy/provider/api/response/ResponseHelper.java
@@ -29,7 +29,7 @@
 public class ResponseHelper {
 
     /**
-     * Creates a response with a message encoded for the given media type. Currently, <code>APPLICATION_JSON</code> and <code>TEXT_PLAIN</code> are supported.
+     * Creates a response with a message encoded for the given media type. Currently, {@code APPLICATION_JSON} and {@code TEXT_PLAIN} are supported.
      */
     public static Response createMessageResponse(Response.Status status, String message, @Nullable MediaType mediaType) {
         if (mediaType != null && APPLICATION_JSON.equals(mediaType.toString())) {

diff --git a/...ider-api/src/main/resources/META-INF/services/org.eclipse.edc.spi.system.ServiceExtension b/...ider-api/src/main/resources/META-INF/services/org.eclipse.edc.spi.system.ServiceExtension
@@ -1 +1,13 @@
+ #
+ #  Copyright (c) 2023 Bayerische Motoren Werke Aktiengesellschaft (BMW AG)
+ #
+ #  This program and the accompanying materials are made available under the
+ #  terms of the Apache License, Version 2.0 which is available at
+ #  https://www.apache.org/licenses/LICENSE-2.0
+ #
+ #  SPDX-License-Identifier: Apache-2.0
+ #
+ #  Contributors:
+ #       Bayerische Motoren Werke Aktiengesellschaft (BMW AG) - initial API and implementation
+
 org.eclipse.tractusx.edc.dataplane.proxy.provider.api.DataPlaneProxyProviderApiExtension
diff --git a/...der-core/src/main/resources/META-INF/services/org.eclipse.edc.spi.system.ServiceExtension b/...der-core/src/main/resources/META-INF/services/org.eclipse.edc.spi.system.ServiceExtension
@@ -1 +1,13 @@
+ #
+ #  Copyright (c) 2023 Bayerische Motoren Werke Aktiengesellschaft (BMW AG)
+ #
+ #  This program and the accompanying materials are made available under the
+ #  terms of the Apache License, Version 2.0 which is available at
+ #  https://www.apache.org/licenses/LICENSE-2.0
+ #
+ #  SPDX-License-Identifier: Apache-2.0
+ #
+ #  Contributors:
+ #       Bayerische Motoren Werke Aktiengesellschaft (BMW AG) - initial API and implementation
+
 org.eclipse.tractusx.edc.dataplane.proxy.provider.core.ProxyProviderCoreExtension
diff --git a/...tractusx/edc/dataplane/proxy/spi/provider/gateway/configuration/GatewayConfiguration.java b/...tractusx/edc/dataplane/proxy/spi/provider/gateway/configuration/GatewayConfiguration.java
@@ -17,8 +17,8 @@
 import static java.util.Objects.requireNonNull;
 
 /**
- * A configuration that exposes a proxied endpoint via an alias. Each configuration is associated with an extensible <code>authorizationType</code> such as
- * {@link #TOKEN_AUTHORIZATION} (the default) and {@link #NO_AUTHORIZATION}. The <code>proxiedPath</code> will be prepended to a request sub-path to create an absolute endpoint
+ * A configuration that exposes a proxied endpoint via an alias. Each configuration is associated with an extensible {@code authorizationType} such as
+ * {@link #TOKEN_AUTHORIZATION} (the default) and {@link #NO_AUTHORIZATION}. The {@code proxiedPath} will be prepended to a request sub-path to create an absolute endpoint
  * URL where data is fetched from.
  */
 public class GatewayConfiguration {