Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade EDC to 0.7.7 #153

Merged
merged 6 commits into from
Nov 18, 2024
Merged

feat: upgrade EDC to 0.7.7 #153

merged 6 commits into from
Nov 18, 2024

Conversation

kss682
Copy link
Contributor

@kss682 kss682 commented Nov 4, 2024

Description

Upgrade EDC to 0.7.7 #134

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

@kss682 kss682 force-pushed the issue134 branch 3 times, most recently from a4763a3 to a354976 Compare November 4, 2024 14:56
@kss682 kss682 requested review from evegufy and matbmoser November 4, 2024 15:24
Copy link
Contributor

@evegufy evegufy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kss682 thank you for your contribution, could you please direct the PR to main and rebase to main?
we need to test this change against the latest in changes in main (i.e. the integration of the SSI DIM Wallet Stub).

@kss682 kss682 changed the base branch from release/R24.08 to main November 5, 2024 13:05
@kss682
Copy link
Contributor Author

kss682 commented Nov 5, 2024

@evegufy The install chart for data exchange test fails with the following error.

client.go:779: 2024-11-05 13:24:58.570327904 +0000 UTC m=+476.531968098 [debug] umbrella-dataprovider-post-install-testdata: Jobs active: 0, jobs failed: 6, jobs succeeded: 0
Error: INSTALLATION FAILED: failed post-install: 1 error occurred:
	* timed out waiting for the condition


helm.go:86: 2024-11-05 13:27:48.190008841 +0000 UTC m=+646.151649064 [debug] failed post-install: 1 error occurred:
	* timed out waiting for the condition

Copy link
Contributor

@CDiezRodriguez CDiezRodriguez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you upgrade the EDC version from 0.7.1 to 0.7.3, the query format may change. You'll need to update the tests to be compatible with version 0.7.3. The tests are located in the resources folder.

Copy link
Contributor

@CDiezRodriguez CDiezRodriguez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I tested it locally, and it works fine.

One tip: The version only needs to be updated once. As long as it's higher than the main version, it should work.

@kss682 kss682 changed the title chore: uprade EDC to 0.7.3 chore: uprade EDC to 0.7.7 Nov 13, 2024
@mgarciaLKS mgarciaLKS self-requested a review November 13, 2024 15:03
@mgarciaLKS
Copy link
Contributor

Also tested it locally and works correctly.

Copy link
Contributor

@matbmoser matbmoser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@kss682 kss682 requested a review from evegufy November 13, 2024 15:18
@evegufy evegufy changed the title chore: uprade EDC to 0.7.7 feat: upgrade EDC to 0.7.7 Nov 13, 2024
Copy link
Contributor

@evegufy evegufy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome that it's working now!
I'd merge once 2.0.5 from @tunacicek is merged #160

@evegufy evegufy merged commit 1531b3b into eclipse-tractusx:main Nov 18, 2024
2 checks passed
@evegufy evegufy mentioned this pull request Nov 18, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants