-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: upgrade EDC to 0.7.7 #153
Conversation
a4763a3
to
a354976
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @kss682 thank you for your contribution, could you please direct the PR to main and rebase to main?
we need to test this change against the latest in changes in main (i.e. the integration of the SSI DIM Wallet Stub).
@evegufy The install chart for data exchange test fails with the following error.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you upgrade the EDC version from 0.7.1 to 0.7.3, the query format may change. You'll need to update the tests to be compatible with version 0.7.3. The tests are located in the resources folder.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I tested it locally, and it works fine.
One tip: The version only needs to be updated once. As long as it's higher than the main version, it should work.
Also tested it locally and works correctly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome that it's working now!
I'd merge once 2.0.5 from @tunacicek is merged #160
Description
Upgrade EDC to 0.7.7 #134
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: