-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Umbrella Chart Configuration for Azure AKS #147
base: release/R24.08
Are you sure you want to change the base?
Umbrella Chart Configuration for Azure AKS #147
Conversation
Most of the changes made in this PR, come from 125. Wouldn't it have been better to have waited for that PR to merge, since it is already checked and tested, and make the PR later, adding only the Azure test stuff? |
Thats actually a good idea, I have added the azure specifc values file. |
We need to wait until #125 is merged. |
What is missing here? |
I think the changes are not updated with the latest ones. |
@saudkhan116 Could you please provide a feedback on this PR? The base branch release/R24.08 is obsolete btw. |
I think the branch needs to be updated, and the base branch should be changed. Should I sync it with main? |
Hey @saudkhan116. |
Hey @mgarciaLKS, yes, you are right. I would close this PR and and simply create a new one with the most updated azure specific values file. |
This PR performs the testing of dim wallet integration with the tx-umbrella components for the tx-community days event and contains Azure configuration values file:
values-test-data-exchange-azure.yaml
file with Azure AKS cluster configurations and dim wallet integrationDescription
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: