Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Umbrella Chart Configuration for Azure AKS #147

Draft
wants to merge 3 commits into
base: release/R24.08
Choose a base branch
from

Conversation

saudkhan116
Copy link

@saudkhan116 saudkhan116 commented Oct 30, 2024

This PR performs the testing of dim wallet integration with the tx-umbrella components for the tx-community days event and contains Azure configuration values file:

  • Added values-test-data-exchange-azure.yaml file with Azure AKS cluster configurations and dim wallet integration

Description

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

@mgarciaLKS
Copy link
Contributor

Most of the changes made in this PR, come from 125. Wouldn't it have been better to have waited for that PR to merge, since it is already checked and tested, and make the PR later, adding only the Azure test stuff?

init-container/iam/sharedidp/CX-Operator-realm.json Outdated Show resolved Hide resolved
charts/umbrella/tx-values.yaml Outdated Show resolved Hide resolved
charts/umbrella/values.yaml Outdated Show resolved Hide resolved
charts/umbrella/values.yaml Outdated Show resolved Hide resolved
charts/umbrella/values.yaml Outdated Show resolved Hide resolved
charts/umbrella/values.yaml Outdated Show resolved Hide resolved
charts/umbrella/values.yaml Outdated Show resolved Hide resolved
charts/umbrella/values.yaml Outdated Show resolved Hide resolved
charts/umbrella/values.yaml Outdated Show resolved Hide resolved
charts/umbrella/values.yaml Outdated Show resolved Hide resolved
@saudkhan116
Copy link
Author

Most of the changes made in this PR, come from 125. Wouldn't it have been better to have waited for that PR to merge, since it is already checked and tested, and make the PR later, adding only the Azure test stuff?

Thats actually a good idea, I have added the azure specifc values file.

@saudkhan116 saudkhan116 marked this pull request as ready for review October 31, 2024 15:04
@saudkhan116 saudkhan116 requested a review from matbmoser October 31, 2024 15:04
@matbmoser matbmoser marked this pull request as draft November 4, 2024 11:04
@matbmoser
Copy link
Contributor

We need to wait until #125 is merged.
I will propose a change here, that you can configure the "base url " of azure of any cloud once and then it will deploy in this "sub-integrate"

@matbmoser
Copy link
Contributor

What is missing here?

@saudkhan116
Copy link
Author

saudkhan116 commented Nov 26, 2024

What is missing here?

I think the changes are not updated with the latest ones.

@saudkhan116 saudkhan116 changed the title dim wallet Integration test in Azure AKS Umbrella Chart Test for Azure Configuration Dec 1, 2024
@saudkhan116 saudkhan116 changed the title Umbrella Chart Test for Azure Configuration Umbrella Chart Configuration for Azure AKS Dec 1, 2024
@evegufy
Copy link
Contributor

evegufy commented Dec 9, 2024

@saudkhan116 Could you please provide a feedback on this PR? The base branch release/R24.08 is obsolete btw.

@saudkhan116
Copy link
Author

@saudkhan116 Could you please provide a feedback on this PR? The base branch release/R24.08 is obsolete btw.

I think the branch needs to be updated, and the base branch should be changed. Should I sync it with main?

@mgarciaLKS
Copy link
Contributor

Hey @saudkhan116.
This PR includes several outdated elements that have already been merged in other PRs.
In my view, the most significant aspect here is the inclusion of the values file for the Azure AKS connection. It would be great to have this file, as it would allow us to test deployment on the server, which would be incredibly helpful. 😊

@saudkhan116
Copy link
Author

Hey @saudkhan116. This PR includes several outdated elements that have already been merged in other PRs. In my view, the most significant aspect here is the inclusion of the values file for the Azure AKS connection. It would be great to have this file, as it would allow us to test deployment on the server, which would be incredibly helpful. 😊

Hey @mgarciaLKS, yes, you are right. I would close this PR and and simply create a new one with the most updated azure specific values file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

5 participants