-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore/e2e irs preparation #109
base: main
Are you sure you want to change the base?
Conversation
Hi @ds-jhartmann : |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments
Hi @tunacicek thanks for the review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good in general!
Could you please update the information about installed components with the discovery-mock in the README.md and add a section about how to use in the adopters section of the README.md?
Also, should the discovery-mock maybe be added to the test file for decentral services https://github.com/eclipse-tractusx/tractus-x-umbrella/blob/chore/e2e-irs-preparation/charts/values-test-data-exchange.yaml?
I'm changing the base branch to main as the update to R24.05 has been merged to main |
Description
This PR includes the following:
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: