Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable EDC Discovery from Portal or Mocked #167

Closed
matbmoser opened this issue Nov 13, 2024 · 6 comments
Closed

Enable EDC Discovery from Portal or Mocked #167

matbmoser opened this issue Nov 13, 2024 · 6 comments
Assignees
Labels
enhancement New feature or request

Comments

@matbmoser
Copy link
Contributor

matbmoser commented Nov 13, 2024

Description

We need the EDC Discovery working with the same interface as defined in the portal.

Problem: We have no EDC registered in the portal, now how do we do it?

Proposals:

  • We can deploy a wiremock. -> The "easy way"
  • Can we seed the portal database with the configured EDCs? -> The maybe hard way

Reason:

  • DPP needs it
  • IRS needs it
@matbmoser
Copy link
Contributor Author

@evegufy can you support us on that? What do you think is the best way?

@evegufy
Copy link
Contributor

evegufy commented Nov 18, 2024

@mgarciaLKS @CDiezRodriguez could you please add a configmap like this one to the umbrella, enable the values here and test if you're able to seed connectors into the portal db? Thank you!
@matbmoser @dvg36 could you please provide the information which companies/BPNs should be seeded out of the seeding data?

@kss682
Copy link
Contributor

kss682 commented Nov 19, 2024

Hello @evegufy ,
When trying to seed the test data into the db, the job yaml here is configured to read from .Values.backend but our umbrella helm is configured on .Values.portal.backend.

@CDiezRodriguez
Copy link
Contributor

Hi @evegufy,
Verified with PR #172 that seeding connectors into the portal works.

@evegufy
Copy link
Contributor

evegufy commented Nov 21, 2024

Hello @evegufy , When trying to seed the test data into the db, the job yaml here is configured to read from .Values.backend but our umbrella helm is configured on .Values.portal.backend.

Hi @kss682 first I thought you meant there was a bug in the portal chart for v2.2.0, but that's not you meant. Yes, sure, the example file which I linked exists in the context of the portal chart so .Values.backend is correct, if it's now supposed to be used in the context of the umbrella you need to introduce the according node .Values.portal.backend

@evegufy
Copy link
Contributor

evegufy commented Nov 21, 2024

Hi @evegufy, Verified with PR #172 that seeding connectors into the portal works.

Hi @CDiezRodriguez
awesome! we might not need to wait for the input of the BPN's and endpoints: I noticed that it's better to make BPNs and connectorURLs configurable in the values file.
So you could introduced templating similar to here into the configMap for the BPNs and connectorURLs.
So could introduce such a structure:

      seeding:
        useDefault: true
        testDataEnvironments: ""
        # -- Option to seed test data provided in a configMap
        testData:
        ...
         companies:
           company1:
             bpn: xxx
             connectorUrl: xxx
           company2:
             bpn: xxx
             connectorUrl: xxx
           etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

No branches or pull requests

4 participants