Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature : sorting by status according to the natural order #944

Conversation

poojapatel23
Copy link

feat: reactivate natural sorting order of notification by status #779

This PR introduces a new feature: reactivate natural sorting order of notifications by status

[Issue]:

[Summary]:

  • This commit provides the sorting order of notifications (alerts and investigations) to follow a natural sorting order based on status. Previously, the sorting method was sorted alphabetically

[Changes Made]:

  • Modified/Added the SQL query responsible for sorting notifications by status.

[Context/Reasoning]:

  • Natural sorting by status provides a more intuitive and user-friendly display of notifications.

 - This commit provides the sorting order of notifications to follow a natural sorting order based on status. Previously, the sorting method was sorted alphabetically
@poojapatel23 poojapatel23 requested a review from ds-lcapellino May 7, 2024 12:44
@poojapatel23 poojapatel23 changed the title Feature/status according to the natural order Feature/Sorting by status according to the natural order May 7, 2024
@poojapatel23 poojapatel23 changed the title Feature/Sorting by status according to the natural order Feature/sorting by status according to the natural order May 7, 2024
@poojapatel23 poojapatel23 changed the title Feature/sorting by status according to the natural order feature : sorting by status according to the natural order May 8, 2024


## [UNRELEASED - 07.05.2024]

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HI @poojapatel23 I would prefer using either the enum in the correct order by taking the nominal or creating an object out of it and giving it a sort index. The database change therefore would not be necessary anymore.

Copy link
Contributor

@ds-mwesener ds-mwesener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please adress comments

@ds-mwesener
Copy link
Contributor

Since we have no changes in this pull request for a long period of time I will close this pull request. Please feel free to open another one with the latest implementation.

@rogocof rogocof deleted the feature/status_according_to_the_natural_order branch August 6, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants