-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Security Bumps and Redesign of create / edit notifications by frontend #852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into feature/623-create-notifications-view # Conflicts: # frontend/src/app/modules/page/notifications/detail/edit/notification-edit.component.ts # frontend/src/app/modules/shared/components/request-notification-new/notification-new-request.component.ts
…into feature/623-create-notifications-view # Conflicts: # frontend/src/app/modules/page/notifications/detail/edit/notification-edit.component.ts # frontend/src/app/modules/shared/components/request-notification-new/notification-new-request.component.ts # frontend/src/app/modules/shared/service/notification.service.ts
…into feature/623-create-notifications-view # Conflicts: # frontend/src/app/modules/page/notifications/detail/edit/notification-edit.component.ts
…tifications-view # Conflicts: # frontend/src/app/modules/page/notifications/detail/edit/notification-edit.component.ts
… -> disable and tooltip.
feature(notifications): 622 - Admin / User should not be able to edit…
# Conflicts: # frontend/src/app/modules/shared/service/notification.service.ts # frontend/src/assets/locales/de/common.json # frontend/src/assets/locales/en/common.json
…-view' into feature/623-create-notifications-view
…le-bpns chore: 774 messages to multiple bpns
Update Dependencies Backend
…-view' into feature/623-create-notifications-view
…-view' into feature/623-create-notifications-view
…-view' into feature/623-create-notifications-view
chore(docs): spell check documentation
…-view' into feature/623-create-notifications-view
…ions-view Feature/623 create notifications view
ds-mmaul
approved these changes
Apr 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added
Changed
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: