Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring of Message History Panel in Trace-X #753

Closed
14 of 17 tasks
Tracked by #449
mkanal opened this issue Mar 15, 2024 · 5 comments · Fixed by #1072, #1076, #1095, #1102 or #1125
Closed
14 of 17 tasks
Tracked by #449

Refactoring of Message History Panel in Trace-X #753

mkanal opened this issue Mar 15, 2024 · 5 comments · Fixed by #1072, #1076, #1095, #1102 or #1125
Assignees
@ds-mmaul
Labels
frontend_refactoring Issues regarding a specific design change in trace-x frontend Frontend related Issues hardening measurements to increase resiliency

Comments

@mkanal
Copy link
Contributor

mkanal commented Mar 15, 2024 •
edited
Loading

As user
I want clearly traceable and comprehensible message history
so that I am able to follow and understand the correct flow of a conversation between multiple BPNLs-.

Link

#423

Hints / Details

Discussion

  • CRUD functions for new attribute IncidentName to notification in seperarte story

Acceptance Criteria

Message Log Detail View

  • Overview Panel in Detail View contains

    • IncidentName ()
    • ID
    • Description
    • Severity
    • BPN Sender
    • BPN Receiver
    • Deadline

  • Message Log contains date separator in case at least one message was created for the certain date

  • Each Message Log Entry contains

    • QualityNotificationStatusResponse (colored Chip)
    • description
    • createdDate
    • Null values are shown as empty fields

Out of Scope

  • Detail window is opened right to the message log entry
  • Detail window contains all information for the message in a key value representation
  • Info button to open detail window

Mockup

image
@mkanal mkanal added this to Trace-X Mar 15, 2024
@github-project-automation github-project-automation bot moved this to inbox in Trace-X Mar 15, 2024
@mkanal mkanal changed the title Refactoring of Message History Panel in Trace-X [WIP] Refactoring of Message History Panel in Trace-X Mar 15, 2024
@mkanal mkanal mentioned this issue Mar 19, 2024
Open
2 tasks
@ds-crehm ds-crehm mentioned this issue Mar 21, 2024
Closed
2 tasks
@mkanal mkanal moved this from inbox to backlog in Trace-X Jun 4, 2024
@mkanal mkanal added frontend Frontend related Issues frontend_refactoring Issues regarding a specific design change in trace-x hardening measurements to increase resiliency labels Jun 4, 2024
@mkanal mkanal changed the title [WIP] Refactoring of Message History Panel in Trace-X Refactoring of Message History Panel in Trace-X Jun 17, 2024
@ds-mmaul ds-mmaul moved this from backlog to wip in Trace-X Jun 19, 2024
@ds-mmaul ds-mmaul self-assigned this Jun 19, 2024
ds-mmaul added a commit that referenced this issue Jun 20, 2024
@ds-mmaul
feature(notification): #753 implement new message history
c9769ef
@github-actions github-actions bot mentioned this issue Jun 20, 2024
Merged
2 tasks
ds-mmaul added a commit that referenced this issue Jun 20, 2024
@ds-mmaul
feature(notification): #753 implement new message history
c41c01c
ds-mmaul added a commit that referenced this issue Jun 20, 2024
@ds-mmaul
feature(notification): #753 implement new message history
d391003
ds-mmaul added a commit that referenced this issue Jun 20, 2024
@ds-mmaul
feature(notification): #753 added tests
bb57ce1
ds-mwesener added a commit that referenced this issue Jun 20, 2024
@ds-mwesener
Merge pull request #1072 from eclipse-tractusx/feature/962-fe-notific…
d4092a3 
…ation-model-change

feature(notification): #753 implement new message history
@ds-mmaul ds-mmaul moved this from wip to test in Trace-X Jun 20, 2024
ds-mmaul added a commit that referenced this issue Jun 20, 2024
@ds-mmaul
feature(notification): #753 align layout
a349ae2
@github-actions github-actions bot mentioned this issue Jun 20, 2024
Merged
2 tasks
ds-mwesener added a commit that referenced this issue Jun 20, 2024
@ds-mwesener
Merge pull request #1076 from eclipse-tractusx/feature/962-fe-notific…
dbe9347 
…ation-model-change

feature(notification): #753 align layout
@ds-mmaul
Copy link
Contributor

Image

@ds-mmaul ds-mmaul mentioned this issue Jun 21, 2024
Merged
2 tasks
@ds-crehm
Copy link
Contributor

ds-crehm commented Jun 24, 2024 •
edited
Loading

Tested on E2E-A:
Image
Layout looks good.

However, not all messages are displayed. For example the following notification has two messages:
grafik
But in the frontend the message history is empty.
grafik

@ds-crehm ds-crehm moved this from test to review in Trace-X Jun 24, 2024
@ds-crehm ds-crehm assigned mkanal and unassigned ds-mmaul Jun 24, 2024
@ds-crehm ds-crehm reopened this Jun 24, 2024
@ds-mwesener ds-mwesener moved this from review to wip in Trace-X Jun 24, 2024
@github-actions github-actions bot mentioned this issue Jun 24, 2024
Merged
2 tasks
@ds-mmaul ds-mmaul moved this from wip to review in Trace-X Jun 24, 2024
@ds-mmaul ds-mmaul assigned ds-crehm and unassigned ds-mmaul Jun 24, 2024
@ds-mmaul
Copy link
Contributor

@ds-crehm , fixed, testable on e2e

@ds-crehm
Copy link
Contributor

LGTM. All messages are now shown in the new layout.
grafik

Ready for review

@ds-crehm ds-crehm reopened this Jun 24, 2024
@ds-crehm ds-crehm removed their assignment Jun 24, 2024
@mkanal mkanal assigned ds-mmaul and unassigned mkanal Jun 26, 2024
@mkanal
Copy link
Contributor Author

mkanal commented Jun 26, 2024

PO acceptance in behalf of @jzbmw. LGFM.

@mkanal mkanal closed this as completed Jun 26, 2024
@mkanal mkanal moved this from review to done in Trace-X Jun 26, 2024
@ds-mmaul ds-mmaul mentioned this issue Jun 27, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ds-mmaul ds-mmaul

Labels
frontend_refactoring Issues regarding a specific design change in trace-x frontend Frontend related Issues hardening measurements to increase resiliency
Projects
Trace-X
Status: done
Milestone
No milestone
3 participants
@mkanal @ds-mmaul @ds-crehm