Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide API on swaggerhub.com #652

Closed
2 tasks done
mkanal opened this issue Feb 13, 2024 · 6 comments · Fixed by catenax-ng/tx-traceability-foss#1067
Closed
2 tasks done

Provide API on swaggerhub.com #652

mkanal opened this issue Feb 13, 2024 · 6 comments · Fixed by catenax-ng/tx-traceability-foss#1067
Assignees
Labels
backend Backend related issues documentation Improvements or additions to documentation spillover temporary label for spill over

Comments

@mkanal
Copy link
Contributor

mkanal commented Feb 13, 2024

As team,
I want to publish api on swaggerhub
so that the api documentation is available for external contributors

Hints / Details

https://app.swaggerhub.com/search?owner=eclipse-tractusx-bot

For APIs with reference implementation:

Please use (or adapt existing) automated workflows to publish on SwaggerHub. Maintain your openAPI.yaml and the publishing workflow in the repository of the reference implementation. Remove everything related to that from the website repo and only link to SwaggerHub in your KIT from now on.
We utilize a user provided by the Eclipse Foundation to publish on SwaggerHub.
Credentials for this user can be used through the eclipse-tractusx GitHub org secrets and can be utilized in automated workflows.
Pay special attention to the "swaggerHub" CLI commands.
The location where the openAPI file is maintained may vary. The BPDM example showcases how the application is initiated to download and publish the current file from that location.

  SWAGGERHUB_API_KEY: ${{ secrets.SWAGGERHUB_API_KEY }}
  SWAGGERHUB_USER: ${{ secrets.SWAGGERHUB_USER }}

Examples:
BPDM Certificate Management: https://github.com/eclipse-tractusx/bpdm-certificate-management/blob/main/.github/workflows/publish-swagger-hub.yaml
Digital Product Pass: https://github.com/eclipse-tractusx/digital-product-pass/blob/main/.github/workflows/publish-swagger-hub.yaml
Tractus-X EDC: https://github.com/eclipse-tractusx/tractusx-edc/blob/main/.github/workflows/publish-swaggerhub.yaml
If you have any questions, please use our “Tractus-X Office Hour” and prepare accordingly before merging.

Outcome / Acceptance Criteria

Outcome

Acceptance Criteria

  • API is available on swaggerhub.com (owner:eclipse-tractusx-bot)
  • Documentation has been updated
@mkanal mkanal added this to Trace-X Feb 13, 2024
@github-project-automation github-project-automation bot moved this to inbox in Trace-X Feb 13, 2024
@jzbmw jzbmw added the documentation Improvements or additions to documentation label Feb 15, 2024
@jzbmw jzbmw changed the title Provide API on swaggerhub.com (eclipse-tractusx-bot) Provide API on swaggerhub.com Feb 23, 2024
@jzbmw jzbmw added the backend Backend related issues label Feb 23, 2024
@mkanal mkanal moved this from inbox to backlog in Trace-X Mar 12, 2024
@ds-lcapellino ds-lcapellino self-assigned this Mar 15, 2024
@ds-lcapellino ds-lcapellino moved this from backlog to wip in Trace-X Mar 15, 2024
@ds-lcapellino ds-lcapellino moved this from wip to test in Trace-X Mar 18, 2024
@mkanal mkanal self-assigned this Mar 18, 2024
@mkanal
Copy link
Contributor Author

mkanal commented Mar 18, 2024

@ds-lcapellino I am not able to see the api right now. Please add link to swaggerhub once this is published. Please add a link where to find documentation adjustments. Thank you very much.

@mkanal mkanal moved this from test to wip in Trace-X Mar 18, 2024
ds-mmaul added a commit that referenced this issue Mar 18, 2024
feature: - #652 add GitHub action to publish Swagger to Swaggerhub
@ds-lcapellino
Copy link
Contributor

ds-lcapellino commented Mar 18, 2024

  • API is available on swaggerhub.com (owner:eclipse-tractusx-bot)
    This is currently not possible, because the maximum amount of APIs is already reached (3)
    Image

  • Documentation has been updated

@ds-lcapellino
Copy link
Contributor

Created issue at sig-infra Team: eclipse-tractusx/sig-infra#455

@ds-lcapellino ds-lcapellino moved this from wip to test in Trace-X Mar 18, 2024
@jzbmw jzbmw added the BLOCKED Issues are blocked by other issues label Mar 19, 2024
@RazvanZmau RazvanZmau added the spillover temporary label for spill over label Mar 19, 2024
@ds-lcapellino ds-lcapellino moved this from test to wip in Trace-X Mar 20, 2024
@ds-lcapellino
Copy link
Contributor

ds-lcapellino commented Mar 20, 2024

Currently, it is not possible to publish more than three APIs on SwaggerHub. It is proposed to publish the OpenApi sepcification of each project on their own GitHub Page. I've created #772 as a followup story to tackle this.

For more information, why it is not possible to upload more than three APIs, please see: https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/4197

@ds-mwesener ds-mwesener moved this from wip to next in Trace-X Mar 20, 2024
@ds-lcapellino
Copy link
Contributor

Followup: #772

@mkanal mkanal removed the BLOCKED Issues are blocked by other issues label Mar 21, 2024
@mkanal mkanal moved this from next to done in Trace-X Mar 21, 2024
@mkanal
Copy link
Contributor Author

mkanal commented Mar 21, 2024

PO acceptance during daily.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Backend related issues documentation Improvements or additions to documentation spillover temporary label for spill over
Projects
Status: done
Development

Successfully merging a pull request may close this issue.

4 participants