Enrich notification with error information if edc communication runs into an error

[ds-mwesener]

As ... a test manager
I want ... to ensure that error information regarding edc communication is not lost
so that ... our end-to-end tests can retry, and the users are informed.

Hints / Details

• Currently our E2E Test are something's failing because the edc can not handle that many requests at once.
• If we would enrich the error into the notification, we could adapt the e2e test to retry, which would cause the test to pass.

Acceptance Criteria

• E2E Tests do not fail because of an edc exception has been thrown.
• E2E will not repeat in an infinity loop
• E2E Tests retry to send notification after a error has occurred
• Frontend displays the error

[jzbmw]

@ds-mwesener I dont get the description. Isn't the behaviour to be tested the one with an working EDC?

[ds-mwesener]

Hi @jzbmw that is correct. Unfortunately sometimes the edc fails while trying to reach the other edc while sending notifications or having contract negotiations.

If this happens our tests will fail. Even though it would be successful in a second try.
For our system to know that there was an error we need to persist that information into our system to be able to perform a retry.
Hope this clarifies it a bit better.

[mkanal]

Important is the result.
This is only allowed for flaky tests, the goal is not to repeat the test as long till the test is successful. Label DISCUSSION_NEEDED was removed as all topics are clarfified.

[ds-crehm]

Successfully tested on E2E.
In the frontend the error message looks like this still:

In the backend the following happens:

And the error message field is filled with information about the error:

E2E tests work properly now.

Frontend display of the error message will be implemented in a different story -> #787

[jzbmw]

@ds-crehm please refer to the story mentioned

[ds-crehm]

During testing we noticed that the corner case of a user sending a notification to his own BPN is not covered in Trace-X yet.
I created the following ticket for it: #783