Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Actions overlapping table columns #1025

Closed
ds-crehm opened this issue Jun 5, 2024 · 7 comments · Fixed by #1215, #1241 or #1245
Closed

[Bug] Actions overlapping table columns #1025

ds-crehm opened this issue Jun 5, 2024 · 7 comments · Fixed by #1215, #1241 or #1245
Assignees
@mkanal
Labels
5 - Frontend Refactoring bug Something isn't working frontend Frontend related Issues

Comments

@ds-crehm
Copy link
Contributor

ds-crehm commented Jun 5, 2024 •
edited
Loading

Description

Table header not going all the way to the right / data rows overlapping column headers at the right side of tables

Current behaviour

Image

Expected behavior

When scrolling down, it should always look like this:
Image

Steps to reproduce the Bug

  1. Open parts table
  2. Scroll all the way to the right of the table
  3. Scroll down
@ds-crehm ds-crehm added this to Trace-X Jun 5, 2024
@github-project-automation github-project-automation bot moved this to inbox in Trace-X Jun 5, 2024
@ds-crehm ds-crehm added frontend Frontend related Issues bug Something isn't working labels Jun 5, 2024
@mkanal mkanal moved this from inbox to backlog in Trace-X Jun 5, 2024
@ds-mmaul
Copy link
Contributor

daily decision: reimplemenent empty menu column header (like it was before) so that the menu icons are not visible when scrolling the table.

@ds-mmaul ds-mmaul self-assigned this Jul 15, 2024
ds-mmaul added a commit that referenced this issue Jul 15, 2024
@ds-mmaul
chore(contracts): #1025 fix overlapping table actions
eb4f48a
@ds-mmaul ds-mmaul moved this from backlog to wip in Trace-X Jul 15, 2024
@ds-mmaul ds-mmaul mentioned this issue Jul 15, 2024
Merged
2 tasks
ds-mmaul added a commit that referenced this issue Jul 16, 2024
@ds-mmaul
Merge pull request #1215 from eclipse-tractusx/chore/#1025-fix-overla…
934c56a 
…pping-table-actions

chore(contracts): #1025 fix overlapping table actions
@ds-mmaul ds-mmaul moved this from wip to test in Trace-X Jul 16, 2024
@ds-crehm
Copy link
Contributor Author

Tested on E2E: LGTM

Ready for review.

@ds-crehm ds-crehm reopened this Jul 16, 2024
@ds-crehm ds-crehm moved this from test to review in Trace-X Jul 16, 2024
@ds-crehm ds-crehm assigned mkanal and unassigned ds-mmaul and ds-crehm Jul 16, 2024
@mkanal
Copy link
Contributor

mkanal commented Jul 17, 2024 •
edited
Loading

@ds-mmaul There is a "-" in asPlanned table. Could you please have a look. Thank.

image

image

image

image

#1232

image

@mkanal mkanal moved this from review to test in Trace-X Jul 18, 2024
@mkanal
Copy link
Contributor

mkanal commented Jul 18, 2024

@ds-crehm please align with the developers.

@ds-mwesener ds-mwesener moved this from test to wip in Trace-X Jul 18, 2024
@ds-mwesener ds-mwesener assigned ds-mwesener and unassigned ds-crehm Jul 18, 2024
@github-actions github-actions bot mentioned this issue Jul 19, 2024
Merged
2 tasks
@ds-mwesener ds-mwesener moved this from wip to test in Trace-X Jul 19, 2024
@ds-mwesener
Copy link
Contributor

The issue with the "-" has been fixed all others are already included in tickets. @ds-crehm please validate.

@ds-mwesener ds-mwesener assigned ds-crehm and unassigned ds-mwesener Jul 19, 2024
@ds-crehm
Copy link
Contributor Author

Tested on E2E: LGTM
"-" doesn't appear anymore.
Ready for review.

@ds-crehm ds-crehm reopened this Jul 19, 2024
@ds-crehm ds-crehm moved this from test to review in Trace-X Jul 19, 2024
@ds-crehm ds-crehm assigned mkanal and unassigned ds-crehm Jul 19, 2024
@mkanal
Copy link
Contributor

mkanal commented Jul 19, 2024

LGFM. PO acceptance in behalf of @jzbmw .

@mkanal mkanal closed this as completed Jul 19, 2024
@mkanal mkanal moved this from review to done in Trace-X Jul 19, 2024
@github-actions github-actions bot mentioned this issue Jul 19, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkanal mkanal

Labels
5 - Frontend Refactoring bug Something isn't working frontend Frontend related Issues
Projects
Trace-X
Status: done
Milestone
No milestone
4 participants
@mkanal @ds-mmaul @ds-mwesener @ds-crehm