Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Implement Expiry Date for BPNL and Membership #192

Conversation

leandro-cavalcante
Copy link
Contributor

@leandro-cavalcante leandro-cavalcante commented Jul 5, 2024

Description

The expiry date was added during the BPNL and Membership creation

Why

There is a bug within the company_ssi_details table where BPNL (Business Partner Number Legal) and Membership credentials are being issued without an expiry date

Issue

N/A

Checklist

Please delete options that are not relevant.

  • I have followed the contributing guidelines
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have added tests that prove my changes work
  • I have checked that new and existing tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas

@jjeroch jjeroch requested review from Phil91 and ntruchsess July 5, 2024 18:34
@jjeroch
Copy link
Contributor

jjeroch commented Jul 5, 2024

Functional Requester: myself
@evegufy can you please switch the branch to /release/v1.1.0-rc.1

@jjeroch jjeroch added the priority PR needs to prioritized at review label Jul 5, 2024
@jjeroch jjeroch mentioned this pull request Jul 5, 2024
7 tasks
@evegufy evegufy changed the base branch from main to release/v1.1.0-rc.1 July 5, 2024 18:47
@evegufy
Copy link
Contributor

evegufy commented Jul 5, 2024

Hi @leandro-cavalcante thanks for your contribution! could you please rebase to the release branch (dropping all the commits which aren't yours?

@leandro-cavalcante leandro-cavalcante force-pushed the bug/Implement-Expiry-for-BPNL-and-Membership-Credentials branch from d2c6df9 to 4511ec0 Compare July 8, 2024 09:07
@leandro-cavalcante
Copy link
Contributor Author

Hi @evegufy, thank you for comments. The branch now is rebased on release/v1.1.0-rc.1.

@ntruchsess ntruchsess merged commit 54dbd0e into eclipse-tractusx:release/v1.1.0-rc.1 Jul 12, 2024
9 checks passed
@jjeroch jjeroch added this to the Release 1.1.0 (24.08) milestone Jul 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority PR needs to prioritized at review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants