-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New submodel IoT_device_definition #84
New submodel IoT_device_definition #84
Conversation
namespace was wrong, added missing full stops in descriptions....
@Cvetanka-ZF you need to rename the model file as well. So please rename IoTSensorDeviceDefinition.ttl to IotSensorDeviceDefinition.ttl (the file needs to have the same name as the aspect contained in the model) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but would suggest to fix the two comments
bamm:preferredName "Manufacturer"@en; | ||
bamm:description "Manufacturer of the IoT Sensor Device."@en; | ||
bamm:characteristic :ManufacturerCharacteristic; | ||
bamm:exampleValue "Openmatics"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would not use real names as this could lead to possible trademark issues,. Maybe just write Company X or Example Company or something like that
bamm:exampleValue "TRACK02839". | ||
:serialNumber a bamm:Property; | ||
bamm:preferredName "IoT Sensor Device Serial Number"@en; | ||
bamm:description "The serial Number of the IoT Sensor device, as assigned by the manufacturer of the device."@en; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Number -> number
Sensor -> sensor
io.catenax.iot_sensor_device_definition/1.0.0/IotSensorDeviceDefinition.ttl
Show resolved
Hide resolved
Modeling_Team |
Description
It is a new submodel which required by the product Asset Tracking (BD Sustainability)
-->
Closes #53
MS2 Criteria
(to be filled out by PR reviewer)
DismantlerId
andDismantlerName
use an EntityDismantler
with the propertiesname
andid
or use a URN likeio.catenax.dismantler:0.0.1
)preferredName
anddescription
are not the samepreferredName
should be human readable and follow normal orthography (e.g., no camel case but normal word separation)MS3 Criteria
(to be filled out by semantic modeling team before merge to main-branch)