-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create shared model to host common properties for Q Semantic models #803
base: main
Are you sure you want to change the base?
Conversation
Still in draft |
This comment was marked as outdated.
This comment was marked as outdated.
Initial
@TorstenHirsch Could you change the name of this PR into
|
@jSchuetz88 Please review the file |
@JulianSchererZF Hi Julian, this is the first working version of the shared model file. |
RC2: metaInformation property integrated
Changed EOL to LF + hex value integration + OEM and Manufacturer-specific part information
Hi @TorstenHirsch, sorry I overlooked the update that this PR is now ready. I will check it in the course of the week. |
Hi Johann,
I will update the core modell today anyhow -> please check this new version instead of the old one.
Thank you. BG Torsten
Mit freundlichen Grüßen / Best regards
Torsten Hirsch
BD/MSA-IPM7
Mobil +49 162 3972185
From: Johann Schütz ***@***.***>
Sent: Monday, February 24, 2025 4:10 PM
To: eclipse-tractusx/sldt-semantic-models ***@***.***>
Cc: Hirsch Torsten (BD/MSA-IPM7 BD/MSA-MQE-Sq4) ***@***.***>; Mention ***@***.***>
Subject: Re: [eclipse-tractusx/sldt-semantic-models] Create shared model to host common properties for Q Semantic models (PR #803)
@JulianSchererZF<https://github.com/JulianSchererZF> Hi Julian, this is the first working version of the shared model file.
Hi @TorstenHirsch<https://github.com/TorstenHirsch>, sorry I overlooked the update that this PR is now ready. I will check it in the course of the week.
—
Reply to this email directly, view it on GitHub<#803 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AYLP65ICS6LDFUAWCM22VFT2RMY3BAVCNFSM6AAAAABTADMO56VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNZYG4ZTANJZG4>.
You are receiving this because you were mentioned.Message ID: ***@***.******@***.***>>
[jSchuetz88]jSchuetz88 left a comment (eclipse-tractusx/sldt-semantic-models#803)<#803 (comment)>
@JulianSchererZF<https://github.com/JulianSchererZF> Hi Julian, this is the first working version of the shared model file.
Hi @TorstenHirsch<https://github.com/TorstenHirsch>, sorry I overlooked the update that this PR is now ready. I will check it in the course of the week.
—
Reply to this email directly, view it on GitHub<#803 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AYLP65ICS6LDFUAWCM22VFT2RMY3BAVCNFSM6AAAAABTADMO56VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNZYG4ZTANJZG4>.
You are receiving this because you were mentioned.Message ID: ***@***.******@***.***>>
|
Hello @jSchuetz88 @JulianSchererZF I updated the model to the latest version -> please check and review. May be we can have a meeting to discuss the results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TorstenHirsch Sorry about the long wait. Overall this model looks good to me. Technically, all MS II criteria are passed. The model as well as the payload validates successfully.
I have two only remarks before approval.
There is the :plantCatenaXId which seems to be the BPNS of the plant. But there are also :catenaXPartId, :catenaXVehicleId, :catenaXQualityTaskId which are a UUID. For me, the usage of "CatenaXIds" as a prefix seem to be more confusing on the semantic level of the terminology and less helpful as multiple aspect models currently use the property and prefix in different ways. Is this prefix mandatory? For example, why not "plantBPNS"?
Description
This PR is to create a shared model to encapsulate common entities and properties in the varios Catena-X Q semantic models.
Initial version of this model will be 1.0.0.
Closes #794
MS2 Criteria
(to be filled out by PR reviewer)
DismantlerId
andDismantlerName
use an EntityDismantler
with the propertiesname
andid
or use a URN likeio.catenax.dismantler:0.0.1
)preferredName
anddescription
are not the samepreferredName
should be human readable and follow normal orthography (e.g., no camel case but normal word separation)MS3 Criteria
(to be filled out by semantic modeling team before merge to main-branch)