Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Updated samm cli to 2.9.0 and AME version to 5.6.0 #766

Closed

Conversation

agg3fe
Copy link
Contributor

@agg3fe agg3fe commented Jul 17, 2024

Description

updated samm cli to 2.9.0 and AME version to 5.6.0

@agg3fe agg3fe requested a review from jSchuetz88 July 17, 2024 09:23
@agg3fe
Copy link
Contributor Author

agg3fe commented Jul 17, 2024

Not to be merged for now.

Copy link
Member

@jSchuetz88 jSchuetz88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the update @agg3fe . We run into some issues / bugs with the generated AASX-files, which should be fixed with the update to SAMM CLI v2.9.0 after a re-generation.

Minor sidenote: Eventually we should consider, to update "bammVersion" to "sammVersion" of the action-scripts, but as it does not affect the functionality, it would only be a non-mandatory patch.

@agg3fe
Copy link
Contributor Author

agg3fe commented Jul 24, 2024

new bug fix version awaited for samm-cli.

@jSchuetz88
Copy link
Member

@agg3fe
It seems, there was an bugfix which fixed a second bug of the AASX serialization: eclipse-esmf/esmf-sdk#632
But no new release so far.

@jSchuetz88
Copy link
Member

As this PR is outdated and the contents have been merged within an other PR, I close this PR.

@jSchuetz88 jSchuetz88 closed this Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants