-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Update model]: Fleet.vehicles add optional components property #714
[Update model]: Fleet.vehicles add optional components property #714
Conversation
Validation Report for io.catenax.fleet.vehicles/2.2.0/Vehicles.ttlInput model is valid |
@agg3fe Please review - Thank you |
modeling_team |
Validation Report for io.catenax.fleet.vehicles/2.2.0/Vehicles.ttlInput model is valid |
As discussed during semantic core team meeting: Change version to 3.0.0
@agg3fe Could you check the model and confirm MS2? I have to check whether I can extract on Friday component enity to a shared model - but if I do not succeed in alignment I definitely need the change in the model with shared model approach |
modeling_team |
@@ -0,0 +1,448 @@ | |||
####################################################################### | |||
# Copyright (c) 2022, 2024 Robert Bosch GmbH |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
your first version was released in 2023. So it should be 2023, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please check few comments
Fix findings from MS-2 review
Validation Report for io.catenax.fleet.vehicles/3.0.0/Vehicles.ttlInput model is valid |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hi @agg3fe , when will the merge happen? |
Description
Inside QAX we checked the latest version of this model. In a bilateral data exchange with real data BMW and Bosch figured out that one optional property is missing components. This property is a list of components and should be used to store identifier for focus components. This helps use quality to overcome the situation that is currently unclear which serial part number of a focus component is installed in a vehicle/ is linked to a hashed VIN.
Closes #712
MS2 Criteria
(to be filled out by PR reviewer)
DismantlerId
andDismantlerName
use an EntityDismantler
with the propertiesname
andid
or use a URN likeio.catenax.dismantler:0.0.1
)preferredName
anddescription
are not the samepreferredName
should be human readable and follow normal orthography (e.g., no camel case but normal word separation)MS3 Criteria
(to be filled out by semantic modeling team before merge to main-branch)