-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Model Update]: Reuse Certificate v3.0.0 #684
Conversation
@agg3fe Please review once the recycling strategy is MS3 approved, Thanks |
@prefix rdf: <http://www.w3.org/1999/02/22-rdf-syntax-ns#> . | ||
@prefix rdfs: <http://www.w3.org/2000/01/rdf-schema#> . | ||
@prefix xsd: <http://www.w3.org/2001/XMLSchema#> . | ||
@prefix : <urn:samm:io.catenax.reuse_certificate:2.1.0#> . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's better to change this model version to 3.0.0 instead 2.1.0. As this is non compatible with previous version and also would be aligned with shared model versions.
@tanweersalah also please update your all PRs again with main branch to incorporate the recycling strategy 3.0.0 model. |
Validation Report for io.catenax.reuse_certificate/3.0.0/ReuseCertificate.ttlInput model is valid |
Feature recycling strategy
Validation Report for io.catenax.reuse_certificate/3.0.0/ReuseCertificate.ttlInput model is valid |
Validation Report for io.catenax.shared.recycling_strategy_certificate/3.0.0/RecyclingStrategyCertificate.ttlInput model is valid |
@agg3fe updated version 2.1.0 to 3.0.0 and merged Recycling strategy 3.0.0 |
@@ -0,0 +1,108 @@ | |||
####################################################################### | |||
# Copyright (c) 2023, 2024 SAP SE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, you don't need to add this model again in the PR. You only need to rebase your branch with main branch. If that is done then it's fine.
Validation Report for io.catenax.reuse_certificate/3.0.0/ReuseCertificate.ttlInput model is valid |
@agg3fe Updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Validation Report for io.catenax.reuse_certificate/3.0.0/ReuseCertificate.ttlInput model is valid |
Validation Report for io.catenax.reuse_certificate/3.0.0/ReuseCertificate.ttlInput model is valid |
Validation Report for io.catenax.reuse_certificate/3.0.0/ReuseCertificate.ttlInput model is valid |
Update Reason
link to the current version of the ReuseCertificate (v2.0.0):
https://github.com/eclipse-tractusx/sldt-semantic-models/blob/main/io.catenax.reuse_certificate/2.0.0/ReuseCertificate.ttl
Issue : #611
Description
-->
Closes #
MS2 Criteria
(to be filled out by PR reviewer)
DismantlerId
andDismantlerName
use an EntityDismantler
with the propertiesname
andid
or use a URN likeio.catenax.dismantler:0.0.1
)preferredName
anddescription
are not the samepreferredName
should be human readable and follow normal orthography (e.g., no camel case but normal word separation)MS3 Criteria
(to be filled out by semantic modeling team before merge to main-branch)