-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[New Model]: Business partner certificate 1.0.0 #673
[New Model]: Business partner certificate 1.0.0 #673
Conversation
Validation Report for io.catenax.shared.business_partner_certificate/1.0.0/BusinessPartnerCertificate.ttlInput model is valid |
io.catenax.shared.business_partner_certificate/1.0.0/BusinessPartnerCertificate.ttl
Show resolved
Hide resolved
io.catenax.shared.business_partner_certificate/1.0.0/gen/BusinessPartnerCertificate.html
Outdated
Show resolved
Hide resolved
io.catenax.shared.business_partner_certificate/1.0.0/BusinessPartnerCertificate.ttl
Outdated
Show resolved
Hide resolved
Validation Report for io.catenax.shared.business_partner_certificate/1.0.0/BusinessPartnerCertificate.ttlInput model is valid |
Hello @agg3fe, I am new to this repo. Kindly confirm about gen folder has to be removed completely(which i have done is recent commit) and do i need to squash the commits as well. |
@SujitMBRDI Thanks for removing gen folder. |
io.catenax.shared.business_partner_certificate/1.0.0/BusinessPartnerCertificate.ttl
Outdated
Show resolved
Hide resolved
io.catenax.shared.business_partner_certificate/1.0.0/BusinessPartnerCertificate.ttl
Outdated
Show resolved
Hide resolved
io.catenax.shared.business_partner_certificate/1.0.0/BusinessPartnerCertificate.ttl
Outdated
Show resolved
Hide resolved
io.catenax.shared.business_partner_certificate/1.0.0/BusinessPartnerCertificate.ttl
Outdated
Show resolved
Hide resolved
io.catenax.shared.business_partner_certificate/1.0.0/BusinessPartnerCertificate.ttl
Outdated
Show resolved
Hide resolved
io.catenax.shared.business_partner_certificate/1.0.0/BusinessPartnerCertificate.ttl
Outdated
Show resolved
Hide resolved
io.catenax.shared.business_partner_certificate/1.0.0/BusinessPartnerCertificate.ttl
Outdated
Show resolved
Hide resolved
io.catenax.shared.business_partner_certificate/1.0.0/BusinessPartnerCertificate.ttl
Outdated
Show resolved
Hide resolved
io.catenax.shared.business_partner_certificate/1.0.0/BusinessPartnerCertificate.ttl
Outdated
Show resolved
Hide resolved
io.catenax.shared.business_partner_certificate/1.0.0/BusinessPartnerCertificate.ttl
Outdated
Show resolved
Hide resolved
io.catenax.shared.business_partner_certificate/RELEASE_NOTES.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please check my comments
@maximilianong I have reviewed the PR and gave some comments. Do you still need tomorrow's meeting? |
Validation Report for io.catenax.shared.business_partner_certificate/1.0.0/BusinessPartnerCertificate.ttlInput model is valid |
Validation Report for io.catenax.shared.business_partner_certificate/1.0.0/BusinessPartnerCertificate.ttlInput model is valid |
@agg3fe, as we discussed yesterday, we have fixed all comments and please have a look on pull request again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
io.catenax.shared.business_partner_certificate/1.0.0/BusinessPartnerCertificate.ttl
Show resolved
Hide resolved
|
||
All notable changes to this model will be documented in this file. | ||
|
||
## [1.0.0] 04.03.2024 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change the date to 11th March.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change the date to 11th March.
Hi @agg3fe, I have adapted date to 11th March.
…per the MS3 approval
Validation Report for io.catenax.shared.business_partner_certificate/1.0.0/BusinessPartnerCertificate.ttlInput model is valid |
Description
In this pull request, created data model for business partner certificates in structured representation of data that defines the relationships, attributes, and meaning of various elements related to certificates issued to or by business partners.
Closes #415
Responsibles for this topic:
@maximilianong, @chkrenn
MS2 Criteria
(to be filled out by PR reviewer)
DismantlerId
andDismantlerName
use an EntityDismantler
with the propertiesname
andid
or use a URN likeio.catenax.dismantler:0.0.1
)preferredName
anddescription
are not the samepreferredName
should be human readable and follow normal orthography (e.g., no camel case but normal word separation)MS3 Criteria
(to be filled out by semantic modeling team before merge to main-branch)