-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Model Update]Pcf #643
[Model Update]Pcf #643
Conversation
Validation Report for io.catenax.pcf/6.0.0/Pcf.ttlInput model is valid |
@agg3fe : there's clarification of three questions outstanding which may have minor implications, so model might need to be updated again. But if possible for you it would be helpful if you could do a first review. MS3 planned for 26-Feb-2024. |
Validation Report for io.catenax.pcf/6.0.0/Pcf.ttlInput model is valid |
Validation Report for io.catenax.pcf/6.0.0/Pcf.ttlInput model is valid |
Validation Report for io.catenax.pcf/6.0.0/Pcf.ttlInput model is valid |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please check a short comment. afterwards we are good for MS2.
Validation Report for io.catenax.pcf/6.0.0/Pcf.ttlInput model is valid |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
fixed see references to other models
Update Pcf.ttl
Validation Report for io.catenax.pcf/6.0.0/Pcf.ttlInput model is valid |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@SMaierTSI example value correction is required. |
Validation Report for io.catenax.pcf/6.0.0/Pcf.ttlInput model is valid |
@agg3fe , @jacewski-bosch : just updated the exemplary "BPN" as discussed in our regular call. PR is ready for merge from my point of view. Thanks again for all your support! |
Description
-->
Closes #575
MS2 Criteria
(to be filled out by PR reviewer)
DismantlerId
andDismantlerName
use an EntityDismantler
with the propertiesname
andid
or use a URN likeio.catenax.dismantler:0.0.1
)preferredName
anddescription
are not the samepreferredName
should be human readable and follow normal orthography (e.g., no camel case but normal word separation)MS3 Criteria
(to be filled out by semantic modeling team before merge to main-branch)