Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Model Update]Pcf #643

Merged
merged 8 commits into from
Feb 27, 2024
Merged

[Model Update]Pcf #643

merged 8 commits into from
Feb 27, 2024

Conversation

SMaierTSI
Copy link
Contributor

@SMaierTSI SMaierTSI commented Feb 13, 2024

Description

-->

Closes #575

MS2 Criteria

(to be filled out by PR reviewer)

  • the model validates with the SAMM SDS SDK in the version specified in the Readme.md of this repository by the time of the MS2 check (e.g., 'java -jar samm-cli.jar aspect <path-to-aspect-model> validate ). The SAMM CLI is available here and in GitHub
  • use Camel-Case (e.g., "MyModelElement" or "TimeDifferenceGmtId", when in doubt follow https://google.github.io/styleguide/javaguide.html#s5.3-camel-case)
  • the identifiers for all model elements start with a capital letter except for properties
  • the identifier for properties starts with a small letter
  • all model elements at least contain the fields "preferred name" and "description" in English language. The description must be comprehensible. It is not required to write full sentences but style should be consistent over the whole model
  • Property and the referenced Characteristic should not have the same name
  • the versioning in the URN follows semantic versioning, where minor version bumps are backwards compatible and major version bumps are not backwards compatible.
  • use abbreviations only when necessary and if these are sufficiently common
  • avoid redundant prefixes in property names (consider adding properties to an enclosing Entity or even adapt the namespace of the model elements, e.g., instead of having two properties DismantlerId and DismantlerName use an Entity Dismantler with the properties name and id or use a URN like io.catenax.dismantler:0.0.1)
  • fields preferredName and description are not the same
  • preferredName should be human readable and follow normal orthography (e.g., no camel case but normal word separation)
  • name of aspect is singular except if it only has one property which is a Collection, List or Set. In theses cases, the aspect name is plural.
  • units are referenced from the SAMM unit catalog whenever possible
  • use constraints to make known constraints from the use case explicit in the aspect model
  • when relying on external standards, they are referenced through a "see" element
  • all properties with an simple type have an example value
  • metadata.json exists with status "release"
  • generated json schema validates against example json payload
  • file RELEASE_NOTES.md exists and contains entries for proposed model changes
  • all contributors to this model are mentioned in copyright header of model file

MS3 Criteria

(to be filled out by semantic modeling team before merge to main-branch)

  • All required reviewers have approved this PR (see reviewers section)
  • The new aspect (version) will be implemented by at least one data provider
  • The new aspect (version) will be consumed by at least one data consumer
  • There exists valid test data
  • In case of a new (incompatible) major version to an existing version, a migration strategy has been developed
  • The model has at least version '1.0.0'
  • If a previous model exists, model deprecation has been checked for previous model
  • The release date in the Release Note is set to the date of the MS3 approval

Copy link

Validation Report for io.catenax.pcf/6.0.0/Pcf.ttl

Input model is valid

@SMaierTSI
Copy link
Contributor Author

@agg3fe : there's clarification of three questions outstanding which may have minor implications, so model might need to be updated again. But if possible for you it would be helpful if you could do a first review. MS3 planned for 26-Feb-2024.

Copy link

Validation Report for io.catenax.pcf/6.0.0/Pcf.ttl

Input model is valid

Copy link

Validation Report for io.catenax.pcf/6.0.0/Pcf.ttl

Input model is valid

@SMaierTSI SMaierTSI marked this pull request as draft February 21, 2024 07:38
Copy link

Validation Report for io.catenax.pcf/6.0.0/Pcf.ttl

Input model is valid

@SMaierTSI SMaierTSI marked this pull request as ready for review February 22, 2024 09:49
Copy link
Contributor

@agg3fe agg3fe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please check a short comment. afterwards we are good for MS2.

Copy link

Validation Report for io.catenax.pcf/6.0.0/Pcf.ttl

Input model is valid

@SMaierTSI SMaierTSI requested a review from agg3fe February 22, 2024 12:16
Copy link
Contributor

@agg3fe agg3fe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agg3fe agg3fe added the MS2_Approved Checklist "MS2 Valid Model" is approved. label Feb 22, 2024
jacewski-bosch and others added 2 commits February 23, 2024 09:02
fixed see references to other models
Copy link

Validation Report for io.catenax.pcf/6.0.0/Pcf.ttl

Input model is valid

Copy link
Contributor

@jacewski-bosch jacewski-bosch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agg3fe
Copy link
Contributor

agg3fe commented Feb 26, 2024

@SMaierTSI example value correction is required.

@agg3fe agg3fe added the MS3_Approved Checklist "MS3 Release Model" is approved. The associated pull request can be merged to the "main-br label Feb 26, 2024
Copy link

Validation Report for io.catenax.pcf/6.0.0/Pcf.ttl

Input model is valid

@SMaierTSI
Copy link
Contributor Author

@agg3fe , @jacewski-bosch : just updated the exemplary "BPN" as discussed in our regular call. PR is ready for merge from my point of view. Thanks again for all your support!

@agg3fe agg3fe merged commit e8bed8e into eclipse-tractusx:main Feb 27, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MS2_Approved Checklist "MS2 Valid Model" is approved. MS3_Approved Checklist "MS3 Release Model" is approved. The associated pull request can be merged to the "main-br
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Model Update]: PCF
3 participants