-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Model Update]: SingleLevelUsageAsPlanned 2.0.0 #640
Merged
agg3fe
merged 14 commits into
eclipse-tractusx:main
from
johannsvarela:update_single_level_usage_as_planned_2.0.0
Feb 28, 2024
Merged
[Model Update]: SingleLevelUsageAsPlanned 2.0.0 #640
agg3fe
merged 14 commits into
eclipse-tractusx:main
from
johannsvarela:update_single_level_usage_as_planned_2.0.0
Feb 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Validation Report for io.catenax.single_level_usage_as_planned/2.0.0/SingleLevelUsageAsPlanned.ttlInput model is valid |
modeling_team |
Validation Report for io.catenax.single_level_usage_as_planned/2.0.0/SingleLevelUsageAsPlanned.ttlInput model is valid |
agg3fe
approved these changes
Feb 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
agg3fe
added
MS1_Approved
Checklist "MS1 Request for Model Developement" is approved.
MS2_Approved
Checklist "MS2 Valid Model" is approved.
and removed
MS1_Approved
Checklist "MS1 Request for Model Developement" is approved.
labels
Feb 16, 2024
Validation Report for io.catenax.single_level_usage_as_planned/2.0.0/SingleLevelUsageAsPlanned.ttlInput model is valid |
Validation Report for io.catenax.single_level_usage_as_planned/2.0.0/SingleLevelUsageAsPlanned.ttlInput model is valid |
Validation Report for io.catenax.single_level_usage_as_planned/2.0.0/SingleLevelUsageAsPlanned.ttlInput model is valid |
Validation Report for io.catenax.single_level_usage_as_planned/2.0.0/SingleLevelUsageAsPlanned.ttlInput model is valid |
Validation Report for io.catenax.single_level_usage_as_planned/2.0.0/SingleLevelUsageAsPlanned.ttlSyntax error in line 124, column 132: Illegal escape sequence value: . (0x2E) 119: samm:dataType xsd:string.
120:
121: :DateTimeRegularExpression a samm-c:RegularExpressionConstraint;
122: samm:preferredName "Date Time Regular Expression"@en;
123: samm:description "Regular Expression to enable UTC and Timezone formats and the possibility to exclude time information."@en;
->124: samm:value "^-?([1-9][0-9]{3,}|0[0-9]{3})-(0[1-9]|1[0-2])-(0[1-9]|[12][0-9]|3[01])(T(([01][0-9]|2[0-3]):[0-5][0-9]:[0-5][0-9](\.[0-9]+)?|(24:00:00(\.0+)?))(Z|(\+|-)((0[0-9]|1[0-3]):[0-5][0-9]|14:00))?)?$".
125:
126: :ValidityPeriodEntity a samm:Entity;
127: samm:preferredName "Validity Period Entity"@en;
128: samm:description "If a validity period only has a start that means that the period is valid from the start date without a (yet)defined enddate and vice versa."@en;
129: samm:properties ([ samm:property :validFrom; samm:optional true ] [ samm:property :validTo; samm:optional true ]). |
1 similar comment
Validation Report for io.catenax.single_level_usage_as_planned/2.0.0/SingleLevelUsageAsPlanned.ttlSyntax error in line 124, column 132: Illegal escape sequence value: . (0x2E) 119: samm:dataType xsd:string.
120:
121: :DateTimeRegularExpression a samm-c:RegularExpressionConstraint;
122: samm:preferredName "Date Time Regular Expression"@en;
123: samm:description "Regular Expression to enable UTC and Timezone formats and the possibility to exclude time information."@en;
->124: samm:value "^-?([1-9][0-9]{3,}|0[0-9]{3})-(0[1-9]|1[0-2])-(0[1-9]|[12][0-9]|3[01])(T(([01][0-9]|2[0-3]):[0-5][0-9]:[0-5][0-9](\.[0-9]+)?|(24:00:00(\.0+)?))(Z|(\+|-)((0[0-9]|1[0-3]):[0-5][0-9]|14:00))?)?$".
125:
126: :ValidityPeriodEntity a samm:Entity;
127: samm:preferredName "Validity Period Entity"@en;
128: samm:description "If a validity period only has a start that means that the period is valid from the start date without a (yet)defined enddate and vice versa."@en;
129: samm:properties ([ samm:property :validFrom; samm:optional true ] [ samm:property :validTo; samm:optional true ]). |
Validation Report for io.catenax.single_level_usage_as_planned/2.0.0/SingleLevelUsageAsPlanned.ttlInput model is valid |
agg3fe
added
the
MS3_Approved
Checklist "MS3 Release Model" is approved. The associated pull request can be merged to the "main-br
label
Feb 26, 2024
Validation Report for io.catenax.single_level_usage_as_planned/2.0.0/SingleLevelUsageAsPlanned.ttlInput model is valid |
@agg3fe Changes on the quantity characteristic were made as @tom-rm-meyer-ISST recommended. Therefore we can merge this PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
MS2_Approved
Checklist "MS2 Valid Model" is approved.
MS3_Approved
Checklist "MS3 Release Model" is approved. The associated pull request can be merged to the "main-br
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Based on continuous development of the Industry Core, the ability to run up the data chain for PartType twins was implemented so that the relationship described by the SingleLevelUsageAsPlanned model meets the requirements of the data chain template.
Closes #633
MS2 Criteria
(to be filled out by PR reviewer)
DismantlerId
andDismantlerName
use an EntityDismantler
with the propertiesname
andid
or use a URN likeio.catenax.dismantler:0.0.1
)preferredName
anddescription
are not the samepreferredName
should be human readable and follow normal orthography (e.g., no camel case but normal word separation)MS3 Criteria
(to be filled out by semantic modeling team before merge to main-branch)