-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Model Update]: SingleLevelBomAsPlanned 3.0.0 #639
[Model Update]: SingleLevelBomAsPlanned 3.0.0 #639
Conversation
Validation Report for io.catenax.single_level_bom_as_planned/3.0.0/SingleLevelBomAsPlanned.ttlInput model is valid |
modeling_team |
samm:exampleValue "BPNL50096894aNXY". | ||
|
||
:childCatenaXId a samm:Property; | ||
samm:preferredName "Catena-X Parent ID"@en; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wrong preferred name
Validation Report for io.catenax.single_level_bom_as_planned/3.0.0/SingleLevelBomAsPlanned.ttlInput model is valid |
@@ -1,7 +1,19 @@ | |||
# Changelog | |||
All notable changes to this model will be documented in this file. | |||
|
|||
## [Unreleased] | |||
## [3.0.0] - 2024-02-19 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please correct release notes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Validation Report for io.catenax.single_level_bom_as_planned/3.0.0/SingleLevelBomAsPlanned.ttlInput model is valid |
Validation Report for io.catenax.single_level_bom_as_planned/3.0.0/SingleLevelBomAsPlanned.ttlInput model is valid |
Validation Report for io.catenax.single_level_bom_as_planned/3.0.0/SingleLevelBomAsPlanned.ttlInput model is valid |
Validation Report for io.catenax.single_level_bom_as_planned/3.0.0/SingleLevelBomAsPlanned.ttlInput model is valid |
Validation Report for io.catenax.single_level_bom_as_planned/3.0.0/SingleLevelBomAsPlanned.ttlInput model is valid |
Validation Report for io.catenax.single_level_bom_as_planned/3.0.0/SingleLevelBomAsPlanned.ttlInput model is valid |
Validation Report for io.catenax.single_level_bom_as_planned/3.0.0/SingleLevelBomAsPlanned.ttlSyntax error in line 113, column 132: Illegal escape sequence value: . (0x2E) 108: samm:dataType xsd:string.
109:
110: :DateTimeRegularExpression a samm-c:RegularExpressionConstraint;
111: samm:preferredName "Date Time Regular Expression"@en;
112: samm:description "Regular Expression to enable UTC and Timezone formats and the possibility to exclude time information."@en;
->113: samm:value "^-?([1-9][0-9]{3,}|0[0-9]{3})-(0[1-9]|1[0-2])-(0[1-9]|[12][0-9]|3[01])(T(([01][0-9]|2[0-3]):[0-5][0-9]:[0-5][0-9](\.[0-9]+)?|(24:00:00(\.0+)?))(Z|(\+|-)((0[0-9]|1[0-3]):[0-5][0-9]|14:00))?)?$".
114:
115: :ValidityPeriodEntity a samm:Entity;
116: samm:preferredName "Validity Period Entity"@en;
117: samm:description "If a validity period only has a start that means that the period is valid from the start date without a (yet)defined enddate and vice versa."@en;
118: samm:properties ([ samm:property :validFrom; samm:optional true ] [ samm:property :validTo; samm:optional true ]). |
Validation Report for io.catenax.single_level_bom_as_planned/3.0.0/SingleLevelBomAsPlanned.ttlSyntax error in line 113, column 132: Illegal escape sequence value: . (0x2E) 108: samm:dataType xsd:string.
109:
110: :DateTimeRegularExpression a samm-c:RegularExpressionConstraint;
111: samm:preferredName "Date Time Regular Expression"@en;
112: samm:description "Regular Expression to enable UTC and Timezone formats and the possibility to exclude time information."@en;
->113: samm:value "^-?([1-9][0-9]{3,}|0[0-9]{3})-(0[1-9]|1[0-2])-(0[1-9]|[12][0-9]|3[01])(T(([01][0-9]|2[0-3]):[0-5][0-9]:[0-5][0-9](\.[0-9]+)?|(24:00:00(\.0+)?))(Z|(\+|-)((0[0-9]|1[0-3]):[0-5][0-9]|14:00))?)?$".
114:
115: :ValidityPeriodEntity a samm:Entity;
116: samm:preferredName "Validity Period Entity"@en;
117: samm:description "If a validity period only has a start that means that the period is valid from the start date without a (yet)defined enddate and vice versa."@en;
118: samm:properties ([ samm:property :validFrom; samm:optional true ] [ samm:property :validTo; samm:optional true ]). |
Validation Report for io.catenax.single_level_bom_as_planned/3.0.0/SingleLevelBomAsPlanned.ttlInput model is valid |
@johannsvarela changes are required. |
Validation Report for io.catenax.single_level_bom_as_planned/3.0.0/SingleLevelBomAsPlanned.ttlInput model is valid |
@agg3fe Changes on the quantity characteristic were made as @tom-rm-meyer-ISST recommended. Therefore we can merge this PR! |
Description
Based on continuous development of the Industry Core, the ability to run down the data chain for PartType twins was implemented so that the relationship described by the SingleLevelBomAsPlanned model meets the requirements of the data chain template.
Closes #632
MS2 Criteria
(to be filled out by PR reviewer)
DismantlerId
andDismantlerName
use an EntityDismantler
with the propertiesname
andid
or use a URN likeio.catenax.dismantler:0.0.1
)preferredName
anddescription
are not the samepreferredName
should be human readable and follow normal orthography (e.g., no camel case but normal word separation)MS3 Criteria
(to be filled out by semantic modeling team before merge to main-branch)