-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[New Model]: PartTypeInformation 1.0.0 #603
[New Model]: PartTypeInformation 1.0.0 #603
Conversation
Validation Report for io.catenax.part_type_information/1.0.0/PartTypeInformation.ttlInput model is valid |
modeling_team |
|
||
## [1.0.0] 2024-01-12 | ||
|
||
- Initial version of the aspect model PartTypeInformation (formely PartAsPlanned) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo formely
Validation Report for io.catenax.part_type_information/1.0.0/PartTypeInformation.ttlInput model is valid |
|
||
:partSitesInformationAsPlannedCharacteristic a samm-c:Set; | ||
samm:preferredName "Part Sites Information as Planned Characteristic"@en; | ||
samm:description "The characteristic of the part site information that represents a set of possible site to a repective part. "@en; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo repective
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please check comments
Validation Report for io.catenax.part_type_information/1.0.0/PartTypeInformation.ttlInput model is valid |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor spacing and writing mistakes in the descriptions which could be fixed.
|
||
:PartTypeInformation a samm:Aspect; | ||
samm:preferredName "Part Type Information"@en; | ||
samm:description "A Part Type Information represents an item in the Catena-X Bill of Material(BOM) on a type level in a specific version. "@en; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
spacing at the end of the sentence
missing space after "Material" (Catena-X Bill of Material(BOM))
|
||
:partTypeInformation a samm:Property; | ||
samm:preferredName "Part Type Information"@en; | ||
samm:description "The part type from which the serialized part has been instantiated"@en; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing dot at the end
|
||
:partSitesInformationAsPlannedCharacteristic a samm-c:Set; | ||
samm:preferredName "Part Sites Information as Planned Characteristic"@en; | ||
samm:description "The characteristic of the part site information that represents a set of possible site to a respective part. "@en; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
spacing at the end of the sentence
|
||
:PartTypeInformationEntity a samm:Entity; | ||
samm:preferredName "Part Type Information Entity"@en; | ||
samm:description "Encapsulation for data related to the part type"@en; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing dot at the end
|
||
:manufacturerPartId a samm:Property; | ||
samm:preferredName "Manufacturer Part ID"@en; | ||
samm:description "Part ID as assigned by the manufacturer of the part. The Part ID identifies the part in the manufacturer`s dataspace. The Part ID references a specific version of a part. The version number must be included in the Part ID if it is available.\n\nThe Part ID does not reference a specific instance of a part and must not be confused with the serial number."@en; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is the line break working like this: "\n\nThe"
|
||
:functionValidUntil a samm:Property; | ||
samm:preferredName "Function valid until"@en; | ||
samm:description "Timestamp, until when the site has the specified function for the given part"@en; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing dot at the end
|
||
:FunctionCharacteristic a samm-c:Enumeration; | ||
samm:preferredName "Function characteristic"@en; | ||
samm:description "Describes the characteristics of the function for a site related to the respective part"@en; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing dot at the end
|
||
:PartIdCharacteristic a samm:Characteristic; | ||
samm:preferredName "Part ID characteristic"@en; | ||
samm:description "The part ID is a multi-character string, usually assigned by an ERP system"@en; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing dot at the end
|
||
:PartNameCharacteristic a samm:Characteristic; | ||
samm:preferredName "Part Name characteristic"@en; | ||
samm:description "Part Name in string format from the respective system in the value chain"@en; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
write "Name" uncapitalized
missing dot at the end
|
||
:partSitesInformationAsPlanned a samm:Property; | ||
samm:preferredName "Part Sites Information as Planned"@en; | ||
samm:description "A site is a delimited geographical area where a legal entity does business(geographical address with geo coordinates).A site always has a primary physical address. It is possible that further physical addresses are specified for the site. P.O. box details are only possible in addition to the physical address. A site has a 1:n relation to addresses, means at least 1 address is necessary and multiple addresses are possible."@en; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing space after first sentence
Validation Report for io.catenax.part_type_information/1.0.0/PartTypeInformation.ttlInput model is valid |
@catroest Thanks for the detailed review! :) I've done a few adjustments, so please have a look the changes again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
..................................................................................................................................................................
This PR replaces the original request to adapt the PartAsPlanned -> #567
..................................................................................................................................................................
Based on the continous development of the Industry Core, the existing PartAsPlanned aspect model will be renamed to PartTypeInformation. Therefore a new aspect model is needed, which contains the same functions as the previous PartAsPlanned 2.0.0.
Additionally these new topics will be done within the implementation of the new/renamed aspect model:
Closes #591 --> Deprecation of the old version (#618) should be done after this PR was merged!
MS2 Criteria
(to be filled out by PR reviewer)
DismantlerId
andDismantlerName
use an EntityDismantler
with the propertiesname
andid
or use a URN likeio.catenax.dismantler:0.0.1
)preferredName
anddescription
are not the samepreferredName
should be human readable and follow normal orthography (e.g., no camel case but normal word separation)MS3 Criteria
(to be filled out by semantic modeling team before merge to main-branch)